Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2282: Don't initialize HadoopCodec (#1071) #1074

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 18, 2023

At Iceberg we want to run Apache Flink without Hadoop, and by initializing HadoopCodec directly, but only if another codec hasn't been provided.

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

At Iceberg we want to run Apache Flink without Hadoop, and
by initializing HadoopCodec directly, but only if another
codec hasn't been provided.
@Fokko
Copy link
Contributor Author

Fokko commented Apr 18, 2023

@wgtmac Creating a backport to 1.13.1 is a great suggestion indeed :)

@Fokko Fokko merged commit 7d74292 into apache:parquet-1.13.x Apr 19, 2023
@Fokko Fokko deleted the fd-backport-2282 branch April 19, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants