Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2407: Add customized .asf.yaml for email notifications #1232

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Dec 4, 2023

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
    from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wgtmac
Copy link
Member Author

wgtmac commented Dec 4, 2023

Per the discussion on ML, I proposed to create an .asf.yaml file for customizing email notification. Please take a look, thanks! @gszadovszky @shangxinli @pitrou @emkornfield

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @wgtmac !

@wgtmac
Copy link
Member Author

wgtmac commented Dec 5, 2023

Thanks @gszadovszky @pitrou! I'll merge it to see what happens. If it works as expected, I'll create a PR for parquet-format as well.

@wgtmac wgtmac merged commit 2d10c28 into apache:master Dec 5, 2023
9 checks passed
@wgtmac
Copy link
Member Author

wgtmac commented Dec 5, 2023

@gszadovszky @julienledem @shangxinli Do you have the permission to change the notification rule here (https://issues.apache.org/jira/plugins/servlet/project-config/PARQUET/notifications)? It sends all JIRA notifications to dev@ ML. It would be good to send them to issues@ ML instead.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants