Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2456: Avoid type name conflicts on fixed type #1304

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Mar 21, 2024

Fixed types with identical names create name type conflicts

For instance, if a parquet message type contains several repeated fixed types, the following error will be thrown:

org.apache.avro.SchemaParseException: Can't redefine: array

Use the same conflict resolution trick used for record types.

@RustedBones RustedBones marked this pull request as ready for review March 22, 2024 09:13
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks for the fix! Would you mind creating a JIRA issue for this?

@RustedBones RustedBones changed the title [parquet-avro] fix: avoid type conflicts on fixed type PARQUET-2456: avoid type conflicts on fixed type Apr 2, 2024
@RustedBones
Copy link
Contributor Author

Sure! Here it is: https://issues.apache.org/jira/browse/PARQUET-2456

@RustedBones RustedBones changed the title PARQUET-2456: avoid type conflicts on fixed type PARQUET-2456: avoid avro schema type conflict on fixed type Apr 2, 2024
@wgtmac wgtmac changed the title PARQUET-2456: avoid avro schema type conflict on fixed type PARQUET-2456: Avoid type name conflicts on fixed type Apr 2, 2024
@wgtmac wgtmac merged commit 67fc368 into apache:master Apr 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants