Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-1341: Fix null count stats in unsigned-sort columns. #499

Merged
merged 2 commits into from
Jul 3, 2018
Merged

PARQUET-1341: Fix null count stats in unsigned-sort columns. #499

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd91f6
Fix null count stats in unsigned-sort columns.
rdblue Jun 28, 2018
f8a885e
Fix test case for old min/max values and unsigned ordering.
rdblue Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...et-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,9 +621,6 @@ public static org.apache.parquet.column.statistics.Statistics fromParquetStatist
statsBuilder.withMin(min);
statsBuilder.withMax(max);
}
if (formatStats.isSetNull_count()) {
statsBuilder.withNumNulls(formatStats.null_count);
}
} else {
boolean isSet = formatStats.isSetMax() && formatStats.isSetMin();
boolean maxEqualsMin = isSet ? Arrays.equals(formatStats.getMin(), formatStats.getMax()) : false;
Expand All @@ -639,11 +636,12 @@ public static org.apache.parquet.column.statistics.Statistics fromParquetStatist
statsBuilder.withMin(formatStats.min.array());
statsBuilder.withMax(formatStats.max.array());
}
if (formatStats.isSetNull_count()) {
statsBuilder.withNumNulls(formatStats.null_count);
}
}
}

if (formatStats.isSetNull_count()) {
statsBuilder.withNumNulls(formatStats.null_count);
}
}
return statsBuilder.build();
}
Expand Down