Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1883 Interpret deprecated INT96 as FIXED[12] in Avro conversion #821

Closed
wants to merge 2 commits into from
Closed

PARQUET-1883 Interpret deprecated INT96 as FIXED[12] in Avro conversion #821

wants to merge 2 commits into from

Conversation

anantdamle
Copy link
Contributor

@anantdamle anantdamle commented Sep 30, 2020

https://issues.apache.org/jira/browse/PARQUET-1883

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"

Tests

  • My PR adds the following unit tests
    TestAvroSchemaConverter.java
    Updated: TestAvroConverters.java

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@anantdamle
Copy link
Contributor Author

Hi team,
How should I proceed? We have many old Parquet files still using INT96, this patch will at least help in reading those files using ParquertIO.readers in Apache Beam.

@anantdamle anantdamle changed the title PARQUET-1883 Interpret deprecated INT96 as LocalDateTime in Avro conversion PARQUET-1883 Interpret deprecated INT96 as FIXED[12] in Avro conversion Oct 17, 2020
@anantdamle anantdamle closed this Oct 19, 2020
@anantdamle anantdamle deleted the int96_reader branch October 19, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant