Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build using GitHub actions #102

Closed
wants to merge 1 commit into from

Conversation

koppor
Copy link

@koppor koppor commented Dec 28, 2020

This PR adds a GitHub workflow to enable checks from all JDKs from version 8 to 15.

The output of GitHub actions is better integrated in GitHub. Furthermore, the errors are highlighted better:

grafik

@THausherr
Copy link
Contributor

Does this mean that each commit will trigger 8 builds, besides the Jenkins builds and the github travis builds? And same for everybody who has forked the project?

@msahyoun
Copy link

@THausherr
Copy link
Contributor

"The ASF maxes out its runner allocation quite often, so a project needs to plan carefully to make best use of them for everyone's sake."

So to me this looks as if "no, won't do" is the answer for now.

@lehmi
Copy link
Contributor

lehmi commented Dec 29, 2020

IMHO it doesn't make that much sense as we don't use github as primary repository, but as readonly mirror. So that those github actions are just another tool to verify our builds after a checkin. As Tilmans pointer shows the number of ASF runners are limited so that we shouldn't allocate them at all for a redundant process.

@koppor
Copy link
Author

koppor commented Dec 31, 2020

OK, got it. I just wanted to make an offer to replace Travis CI. I see ASF having the same limitations as Eclipse Foundation, which I just forgot. Sorry for the noise.

@koppor koppor closed this Dec 31, 2020
@koppor koppor deleted the add-check-to-jdks-8-to-15 branch December 31, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants