-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using parboiled2 as a jar dependency in v1.0.0 #39
Comments
@jrudolph @mdedetrich this is just for discussion but I'd be interested in your views on this |
I will comment on the other stuff later, but I wouldn't advocate for removing/changing this for Java's Base64 class. There is a reason why this Base64 implementation is there, Base64 is used frequently in the context of http and as you can read from the comments its a far more efficient implementation then Java's Base64. Generally speaking its also not unusual for the Akka/Pekko ecosystem to reimplement JVM API's if they are not very efficient (which isn't uncommon) and one of Akka/Pekko's main selling points is performance. As an alternative we can make this base64 into its own sbt module/artifact which would make it fairly easy to add in custom licenses in a similar to what was done with pekko-core's protobuf modules? This can also provide other benefits, i.e. other projects can include specifically just the base64 artifact rather than entire pekko-http if thats all they need. |
This is a duplicate of #1. Basically, I agree with this move. In #14, @mdedetrich suggested to move that change to the 1.1.x release but if it is easy enough to do I would also concur with doing this earlier if it simplifies the license situation. |
Btw. IIRC the original reasoning for vendoring was to avoid a transitive dependency on shapeless (which has now been removed from parboiled2) to avoid having to delay releases until shapeless is out. |
@jrudolph Do you have any comments on the Base64 situation? |
I am fine with doing the change in 1.0.x release if it simplifies the license situation dramatically. pekko-http due to being a http web server/client doesn't have as strict requirements as something like pekko-core |
I'll close this in favour of #1 and link this discussion there |
Also created #40 to discuss Base64 situation specifically |
Relates to #35
The text was updated successfully, but these errors were encountered: