Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Assertion failure caused by exception during pre-start #1384

Closed
pjfanning opened this issue Jul 2, 2024 Discussed in #1383 · 3 comments · Fixed by #1385
Closed

Bug - Assertion failure caused by exception during pre-start #1384

pjfanning opened this issue Jul 2, 2024 Discussed in #1383 · 3 comments · Fixed by #1385
Labels
bug Something isn't working
Milestone

Comments

@pjfanning
Copy link
Contributor

Discussed in #1383

Originally posted by sadekmunawar July 2, 2024
Hi Pekko Team,

Are there any plans to fix this bug in Pekko?
https://discuss.lightbend.com/t/expected-behavior-when-child-actor-throws-an-exception-during-pre-start/10753

Thank you

@pjfanning pjfanning added this to the 1.1.0-M2 milestone Jul 2, 2024
@pjfanning
Copy link
Contributor Author

pjfanning commented Jul 2, 2024

Issue may relate to akka/akka#27614. There is a reproduction test in https://discuss.lightbend.com/t/expected-behavior-when-child-actor-throws-an-exception-during-pre-start/10753/3

If anyone attempts a PR for this - please do not look at the Akka PR. Any Pekko PR will need to be a clean room fix implemented by the PR submitter. The test case in https://discuss.lightbend.com is probably ok to use but it may be worth asking the person who wrote it to give explicit permission for its use in Pekko.

@pjfanning
Copy link
Contributor Author

I think we should consider backporting the fix to 1.0.x branch.

@pjfanning pjfanning reopened this Jul 15, 2024
@Roiocam
Copy link
Member

Roiocam commented Jul 24, 2024

I think we should consider backporting the fix to 1.0.x branch.

all merge requests have been backported to 1.0.x, should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants