-
Notifications
You must be signed in to change notification settings - Fork 1.2k
/
PinotHelixResourceManager.java
3784 lines (3428 loc) · 180 KB
/
PinotHelixResourceManager.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pinot.controller.helix.core;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
import com.google.common.collect.BiMap;
import com.google.common.collect.HashBiMap;
import java.io.IOException;
import java.net.InetAddress;
import java.net.UnknownHostException;
import java.time.Instant;
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Comparator;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.TreeMap;
import java.util.TreeSet;
import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.function.Function;
import java.util.stream.Collectors;
import javax.annotation.Nullable;
import javax.ws.rs.BadRequestException;
import javax.ws.rs.ClientErrorException;
import javax.ws.rs.NotFoundException;
import javax.ws.rs.core.Response;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.configuration.Configuration;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.tuple.Pair;
import org.apache.helix.AccessOption;
import org.apache.helix.ClusterMessagingService;
import org.apache.helix.Criteria;
import org.apache.helix.HelixAdmin;
import org.apache.helix.HelixDataAccessor;
import org.apache.helix.HelixException;
import org.apache.helix.HelixManager;
import org.apache.helix.InstanceType;
import org.apache.helix.PropertyKey;
import org.apache.helix.PropertyKey.Builder;
import org.apache.helix.PropertyPathBuilder;
import org.apache.helix.model.CurrentState;
import org.apache.helix.model.ExternalView;
import org.apache.helix.model.HelixConfigScope;
import org.apache.helix.model.IdealState;
import org.apache.helix.model.InstanceConfig;
import org.apache.helix.model.LiveInstance;
import org.apache.helix.model.Message;
import org.apache.helix.model.ParticipantHistory;
import org.apache.helix.model.StateModelDefinition;
import org.apache.helix.model.builder.HelixConfigScopeBuilder;
import org.apache.helix.store.zk.ZkHelixPropertyStore;
import org.apache.helix.zookeeper.datamodel.ZNRecord;
import org.apache.helix.zookeeper.zkclient.exception.ZkNoNodeException;
import org.apache.pinot.common.assignment.InstanceAssignmentConfigUtils;
import org.apache.pinot.common.assignment.InstancePartitions;
import org.apache.pinot.common.assignment.InstancePartitionsUtils;
import org.apache.pinot.common.config.provider.TableCache;
import org.apache.pinot.common.exception.InvalidConfigException;
import org.apache.pinot.common.exception.SchemaAlreadyExistsException;
import org.apache.pinot.common.exception.SchemaBackwardIncompatibleException;
import org.apache.pinot.common.exception.SchemaNotFoundException;
import org.apache.pinot.common.exception.TableNotFoundException;
import org.apache.pinot.common.lineage.LineageEntry;
import org.apache.pinot.common.lineage.LineageEntryState;
import org.apache.pinot.common.lineage.SegmentLineage;
import org.apache.pinot.common.lineage.SegmentLineageAccessHelper;
import org.apache.pinot.common.lineage.SegmentLineageUtils;
import org.apache.pinot.common.messages.RoutingTableRebuildMessage;
import org.apache.pinot.common.messages.RunPeriodicTaskMessage;
import org.apache.pinot.common.messages.SegmentRefreshMessage;
import org.apache.pinot.common.messages.SegmentReloadMessage;
import org.apache.pinot.common.messages.TableConfigRefreshMessage;
import org.apache.pinot.common.messages.TableDeletionMessage;
import org.apache.pinot.common.metadata.ZKMetadataProvider;
import org.apache.pinot.common.metadata.controllerjob.ControllerJobType;
import org.apache.pinot.common.metadata.instance.InstanceZKMetadata;
import org.apache.pinot.common.metadata.segment.SegmentZKMetadata;
import org.apache.pinot.common.minion.MinionTaskMetadataUtils;
import org.apache.pinot.common.utils.BcryptUtils;
import org.apache.pinot.common.utils.HashUtil;
import org.apache.pinot.common.utils.config.AccessControlUserConfigUtils;
import org.apache.pinot.common.utils.config.InstanceUtils;
import org.apache.pinot.common.utils.config.TableConfigUtils;
import org.apache.pinot.common.utils.config.TagNameUtils;
import org.apache.pinot.common.utils.helix.HelixHelper;
import org.apache.pinot.common.utils.helix.PinotHelixPropertyStoreZnRecordProvider;
import org.apache.pinot.controller.ControllerConf;
import org.apache.pinot.controller.api.exception.ControllerApplicationException;
import org.apache.pinot.controller.api.exception.InvalidTableConfigException;
import org.apache.pinot.controller.api.exception.TableAlreadyExistsException;
import org.apache.pinot.controller.api.exception.UserAlreadyExistsException;
import org.apache.pinot.controller.api.resources.InstanceInfo;
import org.apache.pinot.controller.api.resources.PeriodicTaskInvocationResponse;
import org.apache.pinot.controller.api.resources.StateType;
import org.apache.pinot.controller.helix.core.assignment.instance.InstanceAssignmentDriver;
import org.apache.pinot.controller.helix.core.assignment.segment.SegmentAssignment;
import org.apache.pinot.controller.helix.core.assignment.segment.SegmentAssignmentFactory;
import org.apache.pinot.controller.helix.core.assignment.segment.SegmentAssignmentUtils;
import org.apache.pinot.controller.helix.core.realtime.PinotLLCRealtimeSegmentManager;
import org.apache.pinot.controller.helix.core.rebalance.RebalanceResult;
import org.apache.pinot.controller.helix.core.rebalance.TableRebalancer;
import org.apache.pinot.controller.helix.core.util.ZKMetadataUtils;
import org.apache.pinot.controller.helix.starter.HelixConfig;
import org.apache.pinot.segment.local.utils.ReplicationUtils;
import org.apache.pinot.segment.spi.SegmentMetadata;
import org.apache.pinot.spi.config.ConfigUtils;
import org.apache.pinot.spi.config.instance.Instance;
import org.apache.pinot.spi.config.table.IndexingConfig;
import org.apache.pinot.spi.config.table.SegmentsValidationAndRetentionConfig;
import org.apache.pinot.spi.config.table.TableConfig;
import org.apache.pinot.spi.config.table.TableCustomConfig;
import org.apache.pinot.spi.config.table.TableStats;
import org.apache.pinot.spi.config.table.TableType;
import org.apache.pinot.spi.config.table.TagOverrideConfig;
import org.apache.pinot.spi.config.table.TenantConfig;
import org.apache.pinot.spi.config.table.UpsertConfig;
import org.apache.pinot.spi.config.table.assignment.InstancePartitionsType;
import org.apache.pinot.spi.config.tenant.Tenant;
import org.apache.pinot.spi.config.user.ComponentType;
import org.apache.pinot.spi.config.user.RoleType;
import org.apache.pinot.spi.config.user.UserConfig;
import org.apache.pinot.spi.data.Schema;
import org.apache.pinot.spi.stream.StreamConfig;
import org.apache.pinot.spi.utils.CommonConstants;
import org.apache.pinot.spi.utils.CommonConstants.Helix;
import org.apache.pinot.spi.utils.CommonConstants.Helix.StateModel.BrokerResourceStateModel;
import org.apache.pinot.spi.utils.CommonConstants.Helix.StateModel.SegmentStateModel;
import org.apache.pinot.spi.utils.IngestionConfigUtils;
import org.apache.pinot.spi.utils.InstanceTypeUtils;
import org.apache.pinot.spi.utils.TimeUtils;
import org.apache.pinot.spi.utils.builder.TableNameBuilder;
import org.apache.pinot.spi.utils.retry.RetryPolicies;
import org.apache.pinot.spi.utils.retry.RetryPolicy;
import org.apache.zookeeper.data.Stat;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class PinotHelixResourceManager {
private static final Logger LOGGER = LoggerFactory.getLogger(PinotHelixResourceManager.class);
private static final long CACHE_ENTRY_EXPIRE_TIME_HOURS = 6L;
private static final RetryPolicy DEFAULT_RETRY_POLICY = RetryPolicies.exponentialBackoffRetryPolicy(5, 1000L, 2.0f);
public static final String APPEND = "APPEND";
private static final int DEFAULT_TABLE_UPDATER_LOCKERS_SIZE = 100;
private static final String API_REQUEST_ID_PREFIX = "api-";
// TODO: make this configurable
public static final long EXTERNAL_VIEW_ONLINE_SEGMENTS_MAX_WAIT_MS = 10 * 60_000L; // 10 minutes
public static final long EXTERNAL_VIEW_CHECK_INTERVAL_MS = 1_000L; // 1 second
public static final long SEGMENT_CLEANUP_TIMEOUT_MS = 20 * 60_000L; // 20 minutes
public static final long SEGMENT_CLEANUP_CHECK_INTERVAL_MS = 1_000L; // 1 second
private static final DateTimeFormatter SIMPLE_DATE_FORMAT =
DateTimeFormatter.ofPattern("yyyyMMdd'T'HHmmss'Z'").withZone(ZoneOffset.UTC);
private final Map<String, Map<String, Long>> _segmentCrcMap = new HashMap<>();
private final Map<String, Map<String, Integer>> _lastKnownSegmentMetadataVersionMap = new HashMap<>();
private final Object[] _tableUpdaterLocks;
private final LoadingCache<String, String> _instanceAdminEndpointCache;
private final String _helixZkURL;
private final String _helixClusterName;
private final String _dataDir;
private final boolean _isSingleTenantCluster;
private final boolean _enableBatchMessageMode;
private final boolean _allowHLCTables;
private final int _deletedSegmentsRetentionInDays;
private HelixManager _helixZkManager;
private HelixAdmin _helixAdmin;
private ZkHelixPropertyStore<ZNRecord> _propertyStore;
private HelixDataAccessor _helixDataAccessor;
private Builder _keyBuilder;
private SegmentDeletionManager _segmentDeletionManager;
private PinotLLCRealtimeSegmentManager _pinotLLCRealtimeSegmentManager;
private TableCache _tableCache;
public PinotHelixResourceManager(String zkURL, String helixClusterName, @Nullable String dataDir,
boolean isSingleTenantCluster, boolean enableBatchMessageMode, boolean allowHLCTables,
int deletedSegmentsRetentionInDays) {
_helixZkURL = HelixConfig.getAbsoluteZkPathForHelix(zkURL);
_helixClusterName = helixClusterName;
_dataDir = dataDir;
_isSingleTenantCluster = isSingleTenantCluster;
_enableBatchMessageMode = enableBatchMessageMode;
_deletedSegmentsRetentionInDays = deletedSegmentsRetentionInDays;
_allowHLCTables = allowHLCTables;
_instanceAdminEndpointCache =
CacheBuilder.newBuilder().expireAfterWrite(CACHE_ENTRY_EXPIRE_TIME_HOURS, TimeUnit.HOURS)
.build(new CacheLoader<String, String>() {
@Override
public String load(String instanceId) {
InstanceConfig instanceConfig = getHelixInstanceConfig(instanceId);
Preconditions.checkNotNull(instanceConfig, "Failed to find instance config for: %s", instanceId);
return InstanceUtils.getServerAdminEndpoint(instanceConfig);
}
});
_tableUpdaterLocks = new Object[DEFAULT_TABLE_UPDATER_LOCKERS_SIZE];
for (int i = 0; i < _tableUpdaterLocks.length; i++) {
_tableUpdaterLocks[i] = new Object();
}
}
public PinotHelixResourceManager(ControllerConf controllerConf) {
this(controllerConf.getZkStr(), controllerConf.getHelixClusterName(), controllerConf.getDataDir(),
controllerConf.tenantIsolationEnabled(), controllerConf.getEnableBatchMessageMode(),
controllerConf.getHLCTablesAllowed(), controllerConf.getDeletedSegmentsRetentionInDays());
}
/**
* Starts a Pinot controller instance.
* Note: Helix instance type should be explicitly set to PARTICIPANT ONLY in ControllerStarter.
* Other places like PerfBenchmarkDriver which directly call {@link PinotHelixResourceManager} should NOT register
* as PARTICIPANT,
* which would be put to lead controller resource and mess up the leadership assignment. Those places should use
* SPECTATOR other than PARTICIPANT.
*/
public synchronized void start(HelixManager helixZkManager) {
_helixZkManager = helixZkManager;
_helixAdmin = _helixZkManager.getClusterManagmentTool();
_propertyStore = _helixZkManager.getHelixPropertyStore();
_helixDataAccessor = _helixZkManager.getHelixDataAccessor();
_keyBuilder = _helixDataAccessor.keyBuilder();
_segmentDeletionManager = new SegmentDeletionManager(_dataDir, _helixAdmin, _helixClusterName, _propertyStore,
_deletedSegmentsRetentionInDays);
ZKMetadataProvider.setClusterTenantIsolationEnabled(_propertyStore, _isSingleTenantCluster);
// Initialize TableCache
HelixConfigScope helixConfigScope =
new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(_helixClusterName).build();
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
boolean caseInsensitive =
Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean.parseBoolean(
configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
_tableCache = new TableCache(_propertyStore, caseInsensitive);
}
/**
* Stop the Pinot controller instance.
*/
public synchronized void stop() {
_segmentDeletionManager.stop();
}
/**
* Get the Helix cluster Zookeeper URL.
*
* @return Helix cluster Zookeeper URL
*/
public String getHelixZkURL() {
return _helixZkURL;
}
/**
* Get the Helix cluster name.
*
* @return Helix cluster name
*/
public String getHelixClusterName() {
return _helixClusterName;
}
/**
* Get the segment deletion manager.
*
* @return Segment deletion manager
*/
public SegmentDeletionManager getSegmentDeletionManager() {
return _segmentDeletionManager;
}
/**
* Get the Helix manager.
*
* @return Helix manager
*/
public HelixManager getHelixZkManager() {
return _helixZkManager;
}
/**
* Get the Helix admin.
*
* @return Helix admin
*/
public HelixAdmin getHelixAdmin() {
return _helixAdmin;
}
/**
* Get the Helix property store.
*
* @return Helix property store
*/
public ZkHelixPropertyStore<ZNRecord> getPropertyStore() {
return _propertyStore;
}
/**
* Instance related APIs
*/
/**
* Get all instance Ids.
*
* @return List of instance Ids
*/
public List<String> getAllInstances() {
return _helixAdmin.getInstancesInCluster(_helixClusterName);
}
/**
* Returns the config for all the Helix instances in the cluster.
*/
public List<InstanceConfig> getAllHelixInstanceConfigs() {
return HelixHelper.getInstanceConfigs(_helixZkManager);
}
/**
* Get the Helix instance config for the given instance Id.
*
* @param instanceId Instance Id
* @return Helix instance config
*/
@Nullable
public InstanceConfig getHelixInstanceConfig(String instanceId) {
return _helixDataAccessor.getProperty(_keyBuilder.instanceConfig(instanceId));
}
/**
* Get the instance Zookeeper metadata for the given instance Id.
*
* @param instanceId Instance Id
* @return Instance Zookeeper metadata, or null if not found
*/
@Nullable
public InstanceZKMetadata getInstanceZKMetadata(String instanceId) {
return ZKMetadataProvider.getInstanceZKMetadata(_propertyStore, instanceId);
}
/**
* Get all the broker instances for the given table name.
*
* @param tableName Table name with or without type suffix
* @return List of broker instance Ids
*/
public List<String> getBrokerInstancesFor(String tableName) {
List<InstanceConfig> instanceConfigList = getBrokerInstancesConfigsFor(tableName);
return instanceConfigList.stream().map(InstanceConfig::getInstanceName).collect(Collectors.toList());
}
public List<InstanceConfig> getBrokerInstancesConfigsFor(String tableName) {
String brokerTenantName = null;
TableConfig offlineTableConfig = ZKMetadataProvider.getOfflineTableConfig(_propertyStore, tableName);
if (offlineTableConfig != null) {
brokerTenantName = offlineTableConfig.getTenantConfig().getBroker();
} else {
TableConfig realtimeTableConfig = ZKMetadataProvider.getRealtimeTableConfig(_propertyStore, tableName);
if (realtimeTableConfig != null) {
brokerTenantName = realtimeTableConfig.getTenantConfig().getBroker();
}
}
return HelixHelper.getInstancesConfigsWithTag(HelixHelper.getInstanceConfigs(_helixZkManager),
TagNameUtils.getBrokerTagForTenant(brokerTenantName));
}
public List<InstanceConfig> getAllControllerInstanceConfigs() {
return HelixHelper.getInstanceConfigs(_helixZkManager).stream()
.filter(instance -> InstanceTypeUtils.isController(instance.getId())).collect(Collectors.toList());
}
/**
* Get all instances with the given tag
*/
public List<String> getInstancesWithTag(String tag) {
return HelixHelper.getInstancesWithTag(_helixZkManager, tag);
}
/**
* Add an instance into the Helix cluster.
*
* @param instance Instance to be added
* @param updateBrokerResource Whether to update broker resource for broker instance
* @return Request response
*/
public synchronized PinotResourceManagerResponse addInstance(Instance instance, boolean updateBrokerResource) {
String instanceId = InstanceUtils.getHelixInstanceId(instance);
InstanceConfig instanceConfig = getHelixInstanceConfig(instanceId);
if (instanceConfig != null) {
throw new ClientErrorException(String.format("Instance: %s already exists", instanceId),
Response.Status.CONFLICT);
}
instanceConfig = InstanceUtils.toHelixInstanceConfig(instance);
_helixAdmin.addInstance(_helixClusterName, instanceConfig);
// Update broker resource if necessary
boolean shouldUpdateBrokerResource = false;
List<String> newBrokerTags = null;
if (InstanceTypeUtils.isBroker(instanceId) && updateBrokerResource) {
List<String> newTags = instance.getTags();
if (CollectionUtils.isNotEmpty(newTags)) {
newBrokerTags = newTags.stream().filter(TagNameUtils::isBrokerTag).sorted().collect(Collectors.toList());
shouldUpdateBrokerResource = !newBrokerTags.isEmpty();
}
}
if (shouldUpdateBrokerResource) {
long startTimeMs = System.currentTimeMillis();
List<String> tablesAdded = new ArrayList<>();
HelixHelper.updateBrokerResource(_helixZkManager, instanceId, newBrokerTags, tablesAdded, null);
LOGGER.info("Updated broker resource for broker: {} with tags: {} in {}ms, tables added: {}", instanceId,
newBrokerTags, System.currentTimeMillis() - startTimeMs, tablesAdded);
return PinotResourceManagerResponse.success(
String.format("Added instance: %s, and updated broker resource - tables added: %s", instanceId, tablesAdded));
} else {
return PinotResourceManagerResponse.success("Added instance: " + instanceId);
}
}
/**
* Update a given instance for the specified Instance ID
*/
public synchronized PinotResourceManagerResponse updateInstance(String instanceId, Instance newInstance,
boolean updateBrokerResource) {
InstanceConfig instanceConfig = getHelixInstanceConfig(instanceId);
if (instanceConfig == null) {
throw new NotFoundException("Failed to find instance config for instance: " + instanceId);
}
List<String> newTags = newInstance.getTags();
List<String> oldTags = instanceConfig.getTags();
InstanceUtils.updateHelixInstanceConfig(instanceConfig, newInstance);
if (!_helixDataAccessor.setProperty(_keyBuilder.instanceConfig(instanceId), instanceConfig)) {
throw new RuntimeException("Failed to set instance config for instance: " + instanceId);
}
// Update broker resource if necessary
boolean shouldUpdateBrokerResource = false;
List<String> newBrokerTags = null;
if (InstanceTypeUtils.isBroker(instanceId) && updateBrokerResource) {
newBrokerTags =
newTags != null ? newTags.stream().filter(TagNameUtils::isBrokerTag).sorted().collect(Collectors.toList())
: Collections.emptyList();
List<String> oldBrokerTags =
oldTags.stream().filter(TagNameUtils::isBrokerTag).sorted().collect(Collectors.toList());
shouldUpdateBrokerResource = !newBrokerTags.equals(oldBrokerTags);
}
if (shouldUpdateBrokerResource) {
long startTimeMs = System.currentTimeMillis();
List<String> tablesAdded = new ArrayList<>();
List<String> tablesRemoved = new ArrayList<>();
HelixHelper.updateBrokerResource(_helixZkManager, instanceId, newBrokerTags, tablesAdded, tablesRemoved);
LOGGER.info("Updated broker resource for broker: {} with tags: {} in {}ms, tables added: {}, tables removed: {}",
instanceId, newBrokerTags, System.currentTimeMillis() - startTimeMs, tablesAdded, tablesRemoved);
return PinotResourceManagerResponse.success(
String.format("Updated instance: %s, and updated broker resource - tables added: %s, tables removed: %s",
instanceId, tablesAdded, tablesRemoved));
} else {
return PinotResourceManagerResponse.success("Updated instance: " + instanceId);
}
}
/**
* Updates the tags of the specified instance ID
*/
public synchronized PinotResourceManagerResponse updateInstanceTags(String instanceId, String tagsString,
boolean updateBrokerResource) {
InstanceConfig instanceConfig = getHelixInstanceConfig(instanceId);
if (instanceConfig == null) {
throw new NotFoundException("Failed to find instance config for instance: " + instanceId);
}
List<String> newTags = Arrays.asList(StringUtils.split(tagsString, ','));
List<String> oldTags = instanceConfig.getTags();
instanceConfig.getRecord().setListField(InstanceConfig.InstanceConfigProperty.TAG_LIST.name(), newTags);
if (!_helixDataAccessor.setProperty(_keyBuilder.instanceConfig(instanceId), instanceConfig)) {
throw new RuntimeException("Failed to set instance config for instance: " + instanceId);
}
// Update broker resource if necessary
boolean shouldUpdateBrokerResource = false;
List<String> newBrokerTags = null;
if (InstanceTypeUtils.isBroker(instanceId) && updateBrokerResource) {
newBrokerTags = newTags.stream().filter(TagNameUtils::isBrokerTag).sorted().collect(Collectors.toList());
List<String> oldBrokerTags =
oldTags.stream().filter(TagNameUtils::isBrokerTag).sorted().collect(Collectors.toList());
shouldUpdateBrokerResource = !newBrokerTags.equals(oldBrokerTags);
}
if (shouldUpdateBrokerResource) {
long startTimeMs = System.currentTimeMillis();
List<String> tablesAdded = new ArrayList<>();
List<String> tablesRemoved = new ArrayList<>();
HelixHelper.updateBrokerResource(_helixZkManager, instanceId, newBrokerTags, tablesAdded, tablesRemoved);
LOGGER.info("Updated broker resource for broker: {} with tags: {} in {}ms, tables added: {}, tables removed: {}",
instanceId, newBrokerTags, System.currentTimeMillis() - startTimeMs, tablesAdded, tablesRemoved);
return PinotResourceManagerResponse.success(String.format(
"Updated tags: %s for instance: %s, and updated broker resource - tables added: %s, tables removed: %s",
newTags, instanceId, tablesAdded, tablesRemoved));
} else {
return PinotResourceManagerResponse.success(
String.format("Updated tags: %s for instance: %s", newTags, instanceId));
}
}
/**
* Updates the tables served by the specified broker instance in the broker resource.
* NOTE: This method will read all the table configs, so can be costly.
*/
public PinotResourceManagerResponse updateBrokerResource(String instanceId) {
if (!InstanceTypeUtils.isBroker(instanceId)) {
throw new BadRequestException("Cannot update broker resource for non-broker instance: " + instanceId);
}
InstanceConfig instanceConfig = getHelixInstanceConfig(instanceId);
if (instanceConfig == null) {
throw new NotFoundException("Failed to find instance config for instance: " + instanceId);
}
long startTimeMs = System.currentTimeMillis();
List<String> brokerTags =
instanceConfig.getTags().stream().filter(TagNameUtils::isBrokerTag).collect(Collectors.toList());
List<String> tablesAdded = new ArrayList<>();
List<String> tablesRemoved = new ArrayList<>();
HelixHelper.updateBrokerResource(_helixZkManager, instanceId, brokerTags, tablesAdded, tablesRemoved);
LOGGER.info("Updated broker resource for broker: {} with tags: {} in {}ms, tables added: {}, tables removed: {}",
instanceId, brokerTags, System.currentTimeMillis() - startTimeMs, tablesAdded, tablesRemoved);
return PinotResourceManagerResponse.success(
String.format("Updated broker resource for broker: %s - tables added: %s, tables removed: %s", instanceId,
tablesAdded, tablesRemoved));
}
/**
* Validates whether an instance is offline for certain amount of time.
* Since ZNodes under "/LIVEINSTANCES" are ephemeral, if there is a ZK session expire (e.g. due to network issue),
* the ZNode under "/LIVEINSTANCES" will be deleted. Thus, such race condition can happen when this task is running.
* In order to double confirm the live status of an instance, the field "LAST_OFFLINE_TIME" in ZNode under
* "/INSTANCES/<instance_id>/HISTORY" needs to be checked. If the value is "-1", that means the instance is ONLINE;
* if the value is a timestamp, that means the instance starts to be OFFLINE since that time.
* @param instanceId instance id
* @param offlineTimeRangeMs the time range in milliseconds that it's valid for an instance to be offline
*/
public boolean isInstanceOfflineFor(String instanceId, long offlineTimeRangeMs) {
// Check if the instance is included in /LIVEINSTANCES
if (_helixDataAccessor.getProperty(_keyBuilder.liveInstance(instanceId)) != null) {
return false;
}
ParticipantHistory participantHistory = _helixDataAccessor.getProperty(_keyBuilder.participantHistory(instanceId));
// returns false if there is no history for this participant.
if (participantHistory == null) {
return false;
}
long lastOfflineTime = participantHistory.getLastOfflineTime();
// returns false if the last offline time is a negative number.
if (lastOfflineTime < 0) {
return false;
}
if (System.currentTimeMillis() - lastOfflineTime > offlineTimeRangeMs) {
LOGGER.info("Instance: {} has been offline for more than {}ms", instanceId, offlineTimeRangeMs);
return true;
}
// Still within the offline time range (e.g. due to zk session expire).
return false;
}
/**
* Tenant related APIs
*/
// TODO: move tenant related APIs here
/**
* Resource related APIs
*/
/**
* Get all resource names.
*
* @return List of resource names
*/
public List<String> getAllResources() {
return _helixAdmin.getResourcesInCluster(_helixClusterName);
}
/**
* Get all table names (with type suffix).
*
* @return List of table names
*/
public List<String> getAllTables() {
List<String> tableNames = new ArrayList<>();
for (String resourceName : getAllResources()) {
if (TableNameBuilder.isTableResource(resourceName)) {
tableNames.add(resourceName);
}
}
return tableNames;
}
/**
* Get all offline table names.
*
* @return List of offline table names
*/
public List<String> getAllOfflineTables() {
List<String> offlineTableNames = new ArrayList<>();
for (String resourceName : getAllResources()) {
if (TableNameBuilder.isOfflineTableResource(resourceName)) {
offlineTableNames.add(resourceName);
}
}
return offlineTableNames;
}
/**
* Get all realtime table names.
*
* @return List of realtime table names
*/
public List<String> getAllRealtimeTables() {
List<String> realtimeTableNames = new ArrayList<>();
for (String resourceName : getAllResources()) {
if (TableNameBuilder.isRealtimeTableResource(resourceName)) {
realtimeTableNames.add(resourceName);
}
}
return realtimeTableNames;
}
/**
* Get all raw table names.
*
* @return List of raw table names
*/
public List<String> getAllRawTables() {
Set<String> rawTableNames = new HashSet<>();
for (String resourceName : getAllResources()) {
if (TableNameBuilder.isTableResource(resourceName)) {
rawTableNames.add(TableNameBuilder.extractRawTableName(resourceName));
}
}
return new ArrayList<>(rawTableNames);
}
/**
* Given a table name in any case, returns the table name as defined in Helix/Segment/Schema
* @param tableName tableName in any case.
* @return tableName actually defined in Pinot (matches case) and exists ,else, return the input value
*/
public String getActualTableName(String tableName) {
if (_tableCache.isIgnoreCase()) {
String actualTableName = _tableCache.getActualTableName(tableName);
return actualTableName != null ? actualTableName : tableName;
} else {
return tableName;
}
}
/**
* Table related APIs
*/
// TODO: move table related APIs here
/**
* Segment related APIs
*/
/**
* Returns the segments for the given table.
*
* @param tableNameWithType Table name with type suffix
* @param shouldExcludeReplacedSegments whether to return the list of segments that doesn't contain replaced segments.
* @return List of segment names
*/
public List<String> getSegmentsFor(String tableNameWithType, boolean shouldExcludeReplacedSegments) {
List<String> segmentsFromPropertiesStore = ZKMetadataProvider.getSegments(_propertyStore, tableNameWithType);
if (shouldExcludeReplacedSegments) {
return excludeReplacedSegments(tableNameWithType, segmentsFromPropertiesStore);
}
return segmentsFromPropertiesStore;
}
/**
* Returns the segments for the given table based on the start and end timestamp.
*
* @param tableNameWithType Table name with type suffix
* @param startTimestamp start timestamp in milliseconds (inclusive)
* @param endTimestamp end timestamp in milliseconds (exclusive)
* @param excludeOverlapping whether to exclude the segments overlapping with the timestamps
*/
public List<String> getSegmentsForTableWithTimestamps(String tableNameWithType, long startTimestamp,
long endTimestamp, boolean excludeOverlapping) {
List<String> selectedSegments;
// If no start and end timestamp specified, just select all the segments.
if (startTimestamp == Long.MIN_VALUE && endTimestamp == Long.MAX_VALUE) {
selectedSegments = getSegmentsFor(tableNameWithType, false);
} else {
selectedSegments = new ArrayList<>();
List<SegmentZKMetadata> segmentZKMetadataList = getSegmentsZKMetadata(tableNameWithType);
for (SegmentZKMetadata segmentZKMetadata : segmentZKMetadataList) {
String segmentName = segmentZKMetadata.getSegmentName();
if (isSegmentWithinTimeStamps(segmentZKMetadata, startTimestamp, endTimestamp, excludeOverlapping)) {
selectedSegments.add(segmentName);
}
}
}
return excludeReplacedSegments(tableNameWithType, selectedSegments);
}
/**
* Given the list of segment names, exclude all the replaced segments which cannot be queried.
* @param tableNameWithType table name with type
* @param segments list of input segment names
*/
private List<String> excludeReplacedSegments(String tableNameWithType, List<String> segments) {
// Fetch the segment lineage metadata, and filter segments based on segment lineage.
SegmentLineage segmentLineage = SegmentLineageAccessHelper.getSegmentLineage(_propertyStore, tableNameWithType);
if (segmentLineage == null) {
return segments;
} else {
Set<String> selectedSegmentSet = new HashSet<>(segments);
SegmentLineageUtils.filterSegmentsBasedOnLineageInPlace(selectedSegmentSet, segmentLineage);
return new ArrayList<>(selectedSegmentSet);
}
}
/**
* Checks whether the segment is within the time range between the start and end timestamps.
* @param segmentMetadata the segmentMetadata associated with the segment
* @param startTimestamp start timestamp
* @param endTimestamp end timestamp
* @param excludeOverlapping whether to exclude the segments overlapping with the timestamps
*/
private boolean isSegmentWithinTimeStamps(SegmentZKMetadata segmentMetadata, long startTimestamp, long endTimestamp,
boolean excludeOverlapping) {
if (segmentMetadata == null) {
return false;
}
long startTimeMsInSegment = segmentMetadata.getStartTimeMs();
long endTimeMsInSegment = segmentMetadata.getEndTimeMs();
if (startTimeMsInSegment == -1 && endTimeMsInSegment == -1) {
// No time column specified in the metadata and no minmax value either.
return true;
}
if (startTimeMsInSegment > endTimeMsInSegment) {
LOGGER.warn("Invalid start and end time for segment: {}. Start time: {}. End time: {}",
segmentMetadata.getSegmentName(), startTimeMsInSegment, endTimeMsInSegment);
return false;
}
if (startTimestamp <= startTimeMsInSegment && endTimeMsInSegment < endTimestamp) {
// The segment is within the start and end time range.
return true;
} else if (endTimeMsInSegment < startTimestamp || startTimeMsInSegment >= endTimestamp) {
// The segment is outside of the start and end time range.
return false;
}
// If the segment happens to overlap with the start and end time range,
// check the excludeOverlapping flag to determine whether to include the segment.
return !excludeOverlapping;
}
@Nullable
public SegmentZKMetadata getSegmentZKMetadata(String tableNameWithType, String segmentName) {
return ZKMetadataProvider.getSegmentZKMetadata(_propertyStore, tableNameWithType, segmentName);
}
public List<SegmentZKMetadata> getSegmentsZKMetadata(String tableNameWithType) {
return ZKMetadataProvider.getSegmentsZKMetadata(_propertyStore, tableNameWithType);
}
public synchronized PinotResourceManagerResponse deleteSegments(String tableNameWithType, List<String> segmentNames) {
return deleteSegments(tableNameWithType, segmentNames, null);
}
/**
* Delete a list of segments from ideal state and remove them from the local storage.
*
* @param tableNameWithType Table name with type suffix
* @param segmentNames List of names of segment to be deleted
* @param retentionPeriod The retention period of the deleted segments.
* @return Request response
*/
public synchronized PinotResourceManagerResponse deleteSegments(String tableNameWithType, List<String> segmentNames,
@Nullable String retentionPeriod) {
try {
LOGGER.info("Trying to delete segments: {} from table: {} ", segmentNames, tableNameWithType);
Preconditions.checkArgument(TableNameBuilder.isTableResource(tableNameWithType),
"Table name: %s is not a valid table name with type suffix", tableNameWithType);
HelixHelper.removeSegmentsFromIdealState(_helixZkManager, tableNameWithType, segmentNames);
if (retentionPeriod != null) {
_segmentDeletionManager.deleteSegments(tableNameWithType, segmentNames,
TimeUtils.convertPeriodToMillis(retentionPeriod));
} else {
TableConfig tableConfig = ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
_segmentDeletionManager.deleteSegments(tableNameWithType, segmentNames, tableConfig);
}
return PinotResourceManagerResponse.success("Segment " + segmentNames + " deleted");
} catch (final Exception e) {
LOGGER.error("Caught exception while deleting segment: {} from table: {}", segmentNames, tableNameWithType, e);
return PinotResourceManagerResponse.failure(e.getMessage());
}
}
/**
* Delete a single segment from ideal state and remove it from the local storage.
*
* @param tableNameWithType Table name with type suffix
* @param segmentName Name of segment to be deleted
* @return Request response
*/
public synchronized PinotResourceManagerResponse deleteSegment(String tableNameWithType, String segmentName) {
return deleteSegments(tableNameWithType, Collections.singletonList(segmentName));
}
public PinotResourceManagerResponse updateBrokerTenant(Tenant tenant) {
String brokerTenantTag = TagNameUtils.getBrokerTagForTenant(tenant.getTenantName());
List<String> instancesInClusterWithTag = HelixHelper.getInstancesWithTag(_helixZkManager, brokerTenantTag);
if (instancesInClusterWithTag.size() > tenant.getNumberOfInstances()) {
return scaleDownBroker(tenant, brokerTenantTag, instancesInClusterWithTag);
}
if (instancesInClusterWithTag.size() < tenant.getNumberOfInstances()) {
return scaleUpBroker(tenant, brokerTenantTag, instancesInClusterWithTag);
}
return PinotResourceManagerResponse.SUCCESS;
}
private PinotResourceManagerResponse scaleUpBroker(Tenant tenant, String brokerTenantTag,
List<String> instancesInClusterWithTag) {
List<String> unTaggedInstanceList = getOnlineUnTaggedBrokerInstanceList();
int numberOfInstancesToAdd = tenant.getNumberOfInstances() - instancesInClusterWithTag.size();
if (unTaggedInstanceList.size() < numberOfInstancesToAdd) {
String message = "Failed to allocate broker instances to Tag : " + tenant.getTenantName()
+ ", Current number of untagged broker instances : " + unTaggedInstanceList.size()
+ ", Current number of tagged broker instances : " + instancesInClusterWithTag.size()
+ ", Request asked number is : " + tenant.getNumberOfInstances();
LOGGER.error(message);
return PinotResourceManagerResponse.failure(message);
}
for (int i = 0; i < numberOfInstancesToAdd; i++) {
String instanceName = unTaggedInstanceList.get(i);
retagInstance(instanceName, Helix.UNTAGGED_BROKER_INSTANCE, brokerTenantTag);
// Update idealState by adding new instance to table mapping.
addInstanceToBrokerIdealState(brokerTenantTag, instanceName);
}
return PinotResourceManagerResponse.SUCCESS;
}
public PinotResourceManagerResponse rebuildBrokerResourceFromHelixTags(String tableNameWithType)
throws Exception {
TableConfig tableConfig;
try {
tableConfig = ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
} catch (Exception e) {
LOGGER.warn("Caught exception while getting table config for table {}", tableNameWithType, e);
throw new InvalidTableConfigException(
"Failed to fetch broker tag for table " + tableNameWithType + " due to exception: " + e.getMessage());
}
if (tableConfig == null) {
LOGGER.warn("Table " + tableNameWithType + " does not exist");
throw new InvalidConfigException(
"Invalid table configuration for table " + tableNameWithType + ". Table does not exist");
}
return rebuildBrokerResource(tableNameWithType,
getAllInstancesForBrokerTenant(tableConfig.getTenantConfig().getBroker()));
}
public PinotResourceManagerResponse rebuildBrokerResource(String tableNameWithType, Set<String> brokerInstances) {
IdealState brokerIdealState = HelixHelper.getBrokerIdealStates(_helixAdmin, _helixClusterName);
Set<String> brokerInstancesInIdealState = brokerIdealState.getInstanceSet(tableNameWithType);
if (brokerInstancesInIdealState.equals(brokerInstances)) {
return PinotResourceManagerResponse.success(
"Broker resource is not rebuilt because ideal state is the same for table: " + tableNameWithType);
}
// Update ideal state with the new broker instances
try {
HelixHelper.updateIdealState(getHelixZkManager(), Helix.BROKER_RESOURCE_INSTANCE, idealState -> {
assert idealState != null;
Map<String, String> instanceStateMap = idealState.getInstanceStateMap(tableNameWithType);
if (instanceStateMap != null) {
instanceStateMap.clear();
}
for (String brokerInstance : brokerInstances) {
idealState.setPartitionState(tableNameWithType, brokerInstance, BrokerResourceStateModel.ONLINE);
}
return idealState;
}, DEFAULT_RETRY_POLICY);
LOGGER.info("Successfully rebuilt brokerResource for table: {}", tableNameWithType);
return PinotResourceManagerResponse.success("Rebuilt brokerResource for table: " + tableNameWithType);
} catch (Exception e) {
LOGGER.error("Caught exception while rebuilding broker resource for table: {}", tableNameWithType, e);
throw e;
}
}
private void addInstanceToBrokerIdealState(String brokerTenantTag, String instanceName) {
IdealState tableIdealState = _helixAdmin.getResourceIdealState(_helixClusterName, Helix.BROKER_RESOURCE_INSTANCE);
for (String tableNameWithType : tableIdealState.getPartitionSet()) {
TableConfig tableConfig = ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
Preconditions.checkNotNull(tableConfig);
String brokerTag = TagNameUtils.extractBrokerTag(tableConfig.getTenantConfig());
if (brokerTag.equals(brokerTenantTag)) {
tableIdealState.setPartitionState(tableNameWithType, instanceName, BrokerResourceStateModel.ONLINE);
}
}
_helixAdmin.setResourceIdealState(_helixClusterName, Helix.BROKER_RESOURCE_INSTANCE, tableIdealState);
}
private PinotResourceManagerResponse scaleDownBroker(Tenant tenant, String brokerTenantTag,
List<String> instancesInClusterWithTag) {
int numberBrokersToUntag = instancesInClusterWithTag.size() - tenant.getNumberOfInstances();
for (int i = 0; i < numberBrokersToUntag; i++) {
retagInstance(instancesInClusterWithTag.get(i), brokerTenantTag, Helix.UNTAGGED_BROKER_INSTANCE);
}
return PinotResourceManagerResponse.SUCCESS;
}
private void retagInstance(String instanceName, String oldTag, String newTag) {
_helixAdmin.removeInstanceTag(_helixClusterName, instanceName, oldTag);
_helixAdmin.addInstanceTag(_helixClusterName, instanceName, newTag);
}
public PinotResourceManagerResponse updateServerTenant(Tenant serverTenant) {
String realtimeServerTag = TagNameUtils.getRealtimeTagForTenant(serverTenant.getTenantName());
List<String> taggedRealtimeServers = HelixHelper.getInstancesWithTag(_helixZkManager, realtimeServerTag);
String offlineServerTag = TagNameUtils.getOfflineTagForTenant(serverTenant.getTenantName());
List<String> taggedOfflineServers = HelixHelper.getInstancesWithTag(_helixZkManager, offlineServerTag);
Set<String> allServingServers = new HashSet<>();
allServingServers.addAll(taggedOfflineServers);
allServingServers.addAll(taggedRealtimeServers);
boolean isCurrentTenantColocated =
(allServingServers.size() < taggedOfflineServers.size() + taggedRealtimeServers.size());
if (isCurrentTenantColocated != serverTenant.isCoLocated()) {
String message = "Not support different colocated type request for update request: " + serverTenant;
LOGGER.error(message);
return PinotResourceManagerResponse.failure(message);
}
if (serverTenant.getNumberOfInstances() < allServingServers.size()
|| serverTenant.getOfflineInstances() < taggedOfflineServers.size()
|| serverTenant.getRealtimeInstances() < taggedRealtimeServers.size()) {
return scaleDownServer(serverTenant, taggedRealtimeServers, taggedOfflineServers, allServingServers);
}
return scaleUpServerTenant(serverTenant, realtimeServerTag, taggedRealtimeServers, offlineServerTag,
taggedOfflineServers, allServingServers);
}
private PinotResourceManagerResponse scaleUpServerTenant(Tenant serverTenant, String realtimeServerTag,
List<String> taggedRealtimeServers, String offlineServerTag, List<String> taggedOfflineServers,
Set<String> allServingServers) {
int incInstances = serverTenant.getNumberOfInstances() - allServingServers.size();
List<String> unTaggedInstanceList = getOnlineUnTaggedServerInstanceList();
if (unTaggedInstanceList.size() < incInstances) {
String message = "Failed to allocate hardware resources with tenant info: " + serverTenant
+ ", Current number of untagged instances : " + unTaggedInstanceList.size()
+ ", Current number of serving instances : " + allServingServers.size()
+ ", Current number of tagged offline server instances : " + taggedOfflineServers.size()
+ ", Current number of tagged realtime server instances : " + taggedRealtimeServers.size();
LOGGER.error(message);
return PinotResourceManagerResponse.failure(message);
}
if (serverTenant.isCoLocated()) {
return updateColocatedServerTenant(serverTenant, realtimeServerTag, taggedRealtimeServers, offlineServerTag,
taggedOfflineServers, incInstances, unTaggedInstanceList);
} else {
return updateIndependentServerTenant(serverTenant, realtimeServerTag, taggedRealtimeServers, offlineServerTag,
taggedOfflineServers, incInstances, unTaggedInstanceList);
}