Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELM] Allow statefulsets to automatically roll when updating configmaps #13046

Closed
nilaprasad opened this issue May 1, 2024 · 2 comments
Closed
Assignees

Comments

@nilaprasad
Copy link

Background

Currently, the helm charts don't roll the corresponding pods for a given statefulset when an associated configmap is updated and it needs to be done manually. This can lead to issues where the expected configuration for an environment differs from what's actually there. To allow for quicker iterations on the configuration the helm charts should support automatic rolling of the statefulsets.

Proposed Solution

Allow for an optional annotation that uses helm's ability to automatically roll deployments. For example, this can be set under the controller annotations here.

templates/controller/statefulset.yaml

      ...
      annotations:
        {{- if .Values.controller.automaticReload.enabled }}
        checksum/config: {{ include (print $.Template.BasePath "<configmap-dir>") . | sha256sum }}
{{ toYaml .Values.controller.podAnnotations | indent 8 }}

values.yaml

...
controller:
  ...
  automaticReload:
    enabled: true
  ...
@abhioncbr
Copy link
Collaborator

Looking into it.

@abhioncbr
Copy link
Collaborator

We can close this issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants