Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-stage except ignores all modifier #13127

Closed
gortiz opened this issue May 10, 2024 · 1 comment
Closed

Multi-stage except ignores all modifier #13127

gortiz opened this issue May 10, 2024 · 1 comment
Labels
beginner-task Small task for new contributors to ramp up multi-stage Related to the multi-stage query engine

Comments

@gortiz
Copy link
Contributor

gortiz commented May 10, 2024

Like #13126 but for EXCEPT.

In Postgres:

postgres=# select * from A;
 1
 1
 2
 3
 4

postgres=# select * from B;
 2

postgres=# select * from (select a from A) as a except (select b from B);
 3
 4
 1

postgres=# select * from (select a from A) as a except all (select b from B);
 3
 4
 1
 1

But in Pinot we just ignore the all modifier.

This can be tested in ColocatedJoinEngineQuickStart, where

select count(userUUID) 
from userGroups where userUUID = 'user-5'

returns 2

but

select userUUID
from (select userUUID from userGroups)
except all
(select userUUID from userAttributes where userUUID <> 'user-5')

returns only 1 row.

@gortiz gortiz added beginner-task Small task for new contributors to ramp up multi-stage Related to the multi-stage query engine labels May 10, 2024
@gortiz
Copy link
Contributor Author

gortiz commented May 16, 2024

Done in #13151 by @yashmayya

@gortiz gortiz closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-task Small task for new contributors to ramp up multi-stage Related to the multi-stage query engine
Projects
None yet
Development

No branches or pull requests

1 participant