Enhanced StarTreeIntegrationTest to test group-by results. Added more query of different types to increase test coverage. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshriv
force-pushed
the
star-tree-test-pr
branch
from
606c946
to
23449de
Compare
| double[] actualSums = actualResult.get(expectedKey); | ||
|
|
||
| for (int j = 0; j < expectedSums.length; j++) { | ||
| Assert.assertEquals(expectedSums[j], actualSums[j], |
There was a problem hiding this comment.
The convention is to put actual value as first argument and expected as second. In the error message, no need to explicitly log actual and expected value since they will already show up.
mayankshriv
force-pushed
the
star-tree-test-pr
branch
from
23449de
to
f81ff1b
Compare
| "select sum(m1) from T where d1 <> 'd1-v1' group by d2", | ||
| "select sum(m1) from T where d1 in ('d1-v1', 'd1-v2') group by d2", | ||
| "select sum(m1) from T where d1 in ('d1-v1', 'd1-v2') and d2 not in ('d2-v1') group by d3", | ||
| "select sum(m1) from T where d1 in ('d1-v1', 'd1-v2') and d2 not in ('d2-v1') group by d3, d4" |
There was a problem hiding this comment.
Add a query pattern of "select sum(m1), sum(m2) from T where..."?
There was a problem hiding this comment.
As mentioned in the comment, the test runs aggregation on all metric columns, not just the one in the query, to be more exhaustive.
There was a problem hiding this comment.
Oh, I see. Then it's fine 👍
|
LGTM besides the comments. |
Current coverage is 45.84%
|
Added more query of different types to increase test coverage.
mayankshriv
force-pushed
the
star-tree-test-pr
branch
from
f81ff1b
to
43d2552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.