We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe. Currently, when partitionProducer.internalFlush() is called, it do the following steps:
partitionProducer.internalFlush()
pendingItem
pendingQueue
sendRequest
partitionProducer.ReceivedSendReceipt
This mixed the message sendRequests and the flush sendRequest together which make the code is broken by the if msg!=nil checks.
if msg!=nil
Describe the solution you'd like
pendingItem.Complete()
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here. @merlimat @wolfstudy @RobertIndie
The text was updated successfully, but these errors were encountered:
gunli
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
Currently, when
partitionProducer.internalFlush()
is called, it do the following steps:pendingItem
frompendingQueue
;pendingItem
by appending a newsendRequest
with nil msg and a new callback;partitionProducer.ReceivedSendReceipt
, identify thesendRequest
by checking if the msg is nil.This mixed the message
sendRequest
s and the flushsendRequest
together which make the code is broken by theif msg!=nil
checks.Describe the solution you'd like
pendingItem
, default is nil;partitionProducer.internalFlush()
get the lastpendingItem
frompendingQueue
;pendingItem
by setup a new callback;partitionProducer.ReceivedSendReceipt
, no need to identify thesendRequest
by checking if the msg is nil;pendingItem.Complete()
, invoke its callback to notify the flush is done.Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
@merlimat @wolfstudy @RobertIndie
The text was updated successfully, but these errors were encountered: