Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The AutoRecovery didn't aware rack info after restart. #18671

Closed
2 tasks done
horizonzy opened this issue Nov 29, 2022 · 2 comments · Fixed by #18672
Closed
2 tasks done

[Bug] The AutoRecovery didn't aware rack info after restart. #18671

horizonzy opened this issue Nov 29, 2022 · 2 comments · Fixed by #18672
Labels
Stale type/bug The PR fixed a bug or issue reported a bug

Comments

@horizonzy
Copy link
Member

Search before asking

  • I searched in the issues and found nothing similar.

Version

pulsar: master
auto-recovery: inline in pulsar.

Minimal reproduce step

  1. Use pulsar-admin to set rack info.
  2. Observe the AutoRecovery log, it show that aware the newest rack info.
  3. Restart AutoRecovery, it didn't aware the rack info, stepdown to default rack info /default-region/default-rack

Analyze:
The pulsar works well; the AutoRecovery works badly, the difference is RegistrationClient.
In pulsar, it uses PulsarRegistrationClient to resolve the address; in AutoRecovery, it uses ZKRegistrationClient to resolve the address.

The ZKRegistrationClient only resolves the address registered in zookeeper. PulsarRegistrationClient resolved the address directly, didn't care whether the address was registered in zookeeper or not.

When parsing the rack info, it will resolve the address first, then use the resolved result to build rack info mapping. When AutoRecovery start, it will parse rack info first. At the same time, the ZKRegistrationClient didn't receive the registered
address info, so ZKRegistrationClient can't parse rack info incorrectly.

What did you expect to see?

AutoRecovery also aware the rack info after restart.

What did you see instead?

AutoRecovery didn't aware the rack info after restart.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@horizonzy
Copy link
Member Author

After #17922, pulsar also didn't aware the rack info after it restart.

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
1 participant