pulsar-shell CTRL-C should be interpreted as cancel the current command and should not exit the shell

[pgier]

Search before asking

• I searched in the issues and found nothing similar.

Motivation

When running pulsar-shell, CTRL-C should be used to cancel the current pulsar command instead of a full exit of the program. This would make the behavior more similar to bash and the python shell.

For example, let's say I mistype a command.

> admin topics list pblic/default

Then I want to cancel the current pulsar command, but still stay in the pulsar-shell.

Solution

Catch the CTRL-C and just cancel the current pulsar command instead of exiting completely.

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[lhotari]

There might be technical limitations in intercepting CTRL-C. I remember facing this problem with Grails shell and Gradle continuous build input many years ago. Another possibility is to assign a different hot key for cancelling the current command, for example CTRL-D.

[nicoloboschi]

I fixed it here: #18615

I noticed that actually in the tarball isn't working (using 2.11.0) but within the docker container it works correctly

docker run -v $HOME/.pulsar-shell:/pulsar/.pulsar-shell --rm -it apachepulsar/pulsar:2.11.0 bin/pulsar-shell

I'll investigate more

[nicoloboschi]

I was using a wrong artifact. It works fine also with the artifact here: https://pulsar.apache.org/download/

Have you tried with a command that hangs ? For example, with your command I get

default(localhost)> admin topics list pblic/default
^CException in thread "SIGINT handler" org.apache.pulsar.shell.PulsarShell$InterruptShellException
	at org.apache.pulsar.shell.PulsarShell.lambda$run$2(PulsarShell.java:230)
	at org.jline.terminal.impl.AbstractTerminal.raise(AbstractTerminal.java:89)
	at org.jline.terminal.impl.PosixSysTerminal.lambda$handle$1(PosixSysTerminal.java:65)
	at org.jline.utils.Signals.lambda$register$1(Signals.java:53)
	at jdk.proxy2/jdk.proxy2.$Proxy3.handle(Unknown Source)
	at jdk.unsupported/sun.misc.Signal$InternalMiscHandler.handle(Signal.java:198)
	at java.base/jdk.internal.misc.Signal$1.run(Signal.java:219)
	at java.base/java.lang.Thread.run(Thread.java:833)
HTTP 404 Not Found

Reason: HTTP 404 Not Found

We could hide that exception but it works for me

[pgier]

Ah sorry, I didn't search well enough for existing issues. I wasn't using the latest master when I noticed the issue, and didn't realize this is already fixed.