Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Use correct property when determine if jsr310 enabled #20093

Closed
tisonkun opened this issue Apr 14, 2023 · 1 comment · Fixed by #20201
Closed

[BUG] Use correct property when determine if jsr310 enabled #20093

tisonkun opened this issue Apr 14, 2023 · 1 comment · Fixed by #20201
Labels
area/schema type/bug The PR fixed a bug or issue reported a bug

Comments

@tisonkun
Copy link
Member

It looks like this issue remains unfixed in master.

Originally posted by @dhermanson in #12411 (comment)

When defining a schema using the SchemaDefinitionBuilderImpl, the code was inspecting the incorrect property to determine whether JSR310 should be enabled. This commit changes the builder to inspect the correct property when making this JSR310 enablement determination.
@tisonkun
Copy link
Member Author

@dhermanson I create this issue for tracking this BUG. You're welcome to apply the patch to master branch and we then pick to maintained versions.

@tisonkun tisonkun added type/bug The PR fixed a bug or issue reported a bug area/schema labels Apr 14, 2023
@sijie sijie mentioned this issue Apr 14, 2023
Open
@tisonkun tisonkun mentioned this issue Apr 29, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/schema type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix][client] SchemaDefinition handle JSR310_CONVERSION_ENABLED property tisonkun/pulsar
1 participant
@tisonkun