Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose redeliverUnacknowledgedMessages(Set<MessageIdImpl> messageIds) in the public API #2211

Closed
jnioche opened this issue Jul 20, 2018 · 8 comments
Labels
help wanted type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages type/feature The PR added a new feature or issue requested a new feature

Comments

@jnioche
Copy link

jnioche commented Jul 20, 2018

See discussion on slack

Ideally, I'd love to be able set a delay for when the message(s) will be consumable again. I gather this is not currently possible, but would it be feasible at all or is there something in the architecture that would prevent adding such a feature?

@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jul 24, 2018
@merlimat merlimat added this to the 2.2.0-incubating milestone Jul 24, 2018
@merlimat
Copy link
Contributor

@jnioche Yes, I still agree we should expose this in public API, perhaps with a slightly different signature:

redeliverMessages(Collection<MessageId> messageIds)

@jnioche
Copy link
Author

jnioche commented Jul 24, 2018

thanks @merlimat. What about being able to set a delay? Is that possible?

@sijie sijie added triage/week-30 type/feature The PR added a new feature or issue requested a new feature labels Jul 25, 2018
@ivankelly
Copy link
Contributor

@jnioche could you summarize the slack conversation in the description here?

@sijie sijie modified the milestones: 2.3.0, 2.4.0 Dec 27, 2018
@ConcurrencyPractitioner
Copy link
Contributor

@jnioche @sijie If you are alright with it, I could pick up this one.

@merlimat
Copy link
Contributor

merlimat commented Apr 3, 2019

@ConcurrencyPractitioner I think this is in a way superceded by the negative acks feature in master. At this point I’d wait to see if there is still a gap to be filled, before adding one more API

@jiazhai
Copy link
Member

jiazhai commented Oct 26, 2020

currently negative acks feature is done, this is not blocked anymore. Anyone would like to contribute to this please feel free to comments on this issue.

@MarvinCai
Copy link
Contributor

I think the feature requested for able to ask message(s) to be redelivered with certain delay is supported by this pr: #6449.
Can just close this one.

@jnioche
Copy link
Author

jnioche commented Nov 9, 2020

Haven't checked the PR mentioned above but it looks like it does provide this functionality indeed. Thanks everyone

@jnioche jnioche closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

No branches or pull requests

7 participants