Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It will stop to retry when use SyncSend to send in some case #1013

Closed
cserwen opened this issue Mar 10, 2023 · 0 comments · Fixed by #1014
Closed

It will stop to retry when use SyncSend to send in some case #1013

cserwen opened this issue Mar 10, 2023 · 0 comments · Fixed by #1014
Labels
bug Something isn't working
Milestone

Comments

@cserwen
Copy link
Member

cserwen commented Mar 10, 2023

BUG REPORT

Currently in SyncSend, retries are only worked when there is a network error, but not for common errors such as Broker busy

res, _err := p.client.InvokeSync(ctx, addr, p.buildSendRequest(mq, msg), 3*time.Second)
if _err != nil {
	err = _err
	continue
}

return p.client.ProcessSendResponse(mq.BrokerName, res, resp, msg)

In java SDK, It will retry for broker_busyservicce not available and so on. And It will select a different broker to retry.

This is very helpful in a multi-Broker cluster, so I think it is necessary to fix this problem.

@cserwen cserwen changed the title It will stop to retry when use SyncSend to send It will stop to retry when use SyncSend to send in some case Mar 10, 2023
@cserwen cserwen added the enhancement New feature or request label Mar 10, 2023
@francisoliverlee francisoliverlee added bug Something isn't working and removed enhancement New feature or request labels Mar 20, 2023
@cserwen cserwen added this to the 2.1.2 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants