We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG REPORT
rocketmq-client-go/internal/request_response_future.go
Lines 54 to 57 in 6c77b67
https://github.com/apache/rocketmq/blob/e7f29798ece70e218f7233a7ec85f01e8706a062/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java#L67
Since we already use chan Done to sync the write and read of response message, there is no need to use mutex:
Done
Lines 133 to 145 in 6c77b67
Consider edge cases, we should add non-blocking check of chan Done before calculate timeout, to avoid any possibility of duplicate callback:
Lines 147 to 150 in 6c77b67
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
BUG REPORT
rocketmq-client-go/internal/request_response_future.go
Lines 54 to 57 in 6c77b67
https://github.com/apache/rocketmq/blob/e7f29798ece70e218f7233a7ec85f01e8706a062/client/src/main/java/org/apache/rocketmq/client/producer/RequestFutureHolder.java#L67
Since we already use chan
Done
to sync the write and read of response message, there is no need to use mutex:rocketmq-client-go/internal/request_response_future.go
Lines 133 to 145 in 6c77b67
Consider edge cases, we should add non-blocking check of chan Done before calculate timeout, to avoid any possibility of duplicate callback:
rocketmq-client-go/internal/request_response_future.go
Lines 147 to 150 in 6c77b67
The text was updated successfully, but these errors were encountered: