Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsumerSendMsgBackRequest should not send message body. #780

Closed
lifepuzzlefun opened this issue Mar 2, 2022 · 2 comments · Fixed by #865
Closed

ConsumerSendMsgBackRequest should not send message body. #780

lifepuzzlefun opened this issue Mar 2, 2022 · 2 comments · Fixed by #865
Labels
enhancement New feature or request

Comments

@lifepuzzlefun
Copy link
Contributor

lifepuzzlefun commented Mar 2, 2022

see

func (pc *pushConsumer) buildSendBackRequest(msg *primitive.MessageExt, delayLevel int) *remote.RemotingCommand {
req := &internal.ConsumerSendMsgBackRequestHeader{
Group: pc.consumerGroup,
OriginTopic: msg.Topic,
Offset: msg.CommitLogOffset,
DelayLevel: delayLevel,
OriginMsgId: msg.MsgId,
MaxReconsumeTimes: pc.getMaxReconsumeTimes(),
}
return remote.NewRemotingCommand(internal.ReqConsumerSendMsgBack, req, msg.Body)
}

the broker will not process remotingCommand body we can remove the msg body here.

@stale
Copy link

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2022
@lifepuzzlefun
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants