Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context of primitive.WithMethod bug in producer.go #847

Closed
domyway opened this issue Jun 22, 2022 · 0 comments · Fixed by #837
Closed

context of primitive.WithMethod bug in producer.go #847

domyway opened this issue Jun 22, 2022 · 0 comments · Fixed by #837

Comments

@domyway
Copy link
Contributor

domyway commented Jun 22, 2022

`
if p.interceptor != nil ; then:
primitive.WithMethod(ctx, primitive.SendSync) must change to ctx = primitive.WithMethod(ctx, primitive.SendSync)
primitive.WithMethod(ctx, primitive.SendAsync) must change to ctx = primitive.WithMethod(ctx, primitive.SendAsync)
primitive.WithMethod(ctx, primitive.SendOneway) must change to ctx = primitive.WithMethod(ctx, primitive.SendOneway)

`
this is my PR #837 or anyone fix this bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #847] fix primitive.WithMethod ctx transfer domyway/rocketmq-client-go
1 participant
@domyway