Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init frontend dashboard #36

Merged
merged 1 commit into from Nov 13, 2021

Conversation

suvllian
Copy link

@suvllian suvllian commented Nov 1, 2021

What is the purpose of the change

#11

use ant design pro to setup frontend dashboard

Brief changelog

  1. choose frontend framework
  2. init frontend dashboard

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@vongosling
Copy link
Member

We should point to the new dev branch for this architecture update.

@StyleTang
Copy link
Member

Thanks👍, this is really a huge change, could you change the merge branch to develop?

I have 2 overall comments:

  1. There are a lot of useless files that need to be deleted, we should keep our project simple and easy to maintain.
  2. Need to add the Apache V2 license header to each file.

There might be a lot of work to do, I will work with you to finish this PR.
Thanks again for your contribution.

@vongosling vongosling changed the base branch from master to develop November 3, 2021 07:18
@1994
Copy link

1994 commented Nov 10, 2021

I suggest using Typescript instead of Javascript. Typescript is more friendly to Java developer and has better maintenance.

@StyleTang
Copy link
Member

I suggest using Typescript instead of Javascript. Typescript is more friendly to Java developer and has better maintenance.

@1994
Agree, strongly typed languages are easier to maintain, this PR already using Typescript.
Are you interested in contributing together~

@StyleTang StyleTang merged commit 21c2c3a into apache:develop Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants