Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate ErrorProne into the maven build #1598

Open
tianchen92 opened this issue Nov 15, 2019 · 2 comments
Open

Incorporate ErrorProne into the maven build #1598

tianchen92 opened this issue Nov 15, 2019 · 2 comments
Labels
no stale This will never be considered stale progress/discuss

Comments

@tianchen92
Copy link

FEATURE REQUEST

  1. Using https://github.com/google/error-prone seems like it would be a good idea to automatically catch more errors.

This could catch more potential exceptions (example see https://errorprone.info/)

I would like to work on this issue.

@duhenglucky
Copy link
Contributor

@tianchen92 It looks like a very interesting job :), could you give a more detailed design, or list some benefits about this integration?

@tianchen92
Copy link
Author

Sorry for the delay, the integration is very simple, just config in the root pom and it will work when run "mvn clean install", it will fail when it catch potential problems match error-prone bug patterns, such as this one: http://errorprone.info/bugpattern/DeadException

In this way, with little change, we could introduce error-prone and it will improve our code quality in future I think.

@aaron-ai aaron-ai added the no stale This will never be considered stale label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale This will never be considered stale progress/discuss
Projects
None yet
Development

No branches or pull requests

4 participants