Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build docker image #4704

Closed
luban8hao opened this issue Jul 28, 2022 · 11 comments
Closed

build docker image #4704

luban8hao opened this issue Jul 28, 2022 · 11 comments

Comments

@luban8hao
Copy link

How to rebuild new Docker images after modifying the RocketMQ source code, based on our modified source code?

@ltamber
Copy link
Contributor

ltamber commented Jul 28, 2022

you can look at rocketmq-docker, and edit the Dockerfile and replace the file rocketmq-all-${ROCKETMQ_VERSION}-bin-release.zip

@luban8hao
Copy link
Author

you can look at rocketmq-docker, and edit the Dockerfile and replace the file rocketmq-all-${ROCKETMQ_VERSION}-bin-release.zip

However, after we modified the source code and packaged it into a JAR package with Maven, the directory structure and contents of the ZIP package are different

@luban8hao
Copy link
Author

you can look at rocketmq-docker, and edit the Dockerfile and replace the file rocketmq-all-${ROCKETMQ_VERSION}-bin-release.zip

Jars packaged with Maven do not have a bin directory

@ltamber
Copy link
Contributor

ltamber commented Jul 28, 2022

Jars packaged with Maven do not have a bin directory

Did you follow this BUILDING GUIDE ?

@luban8hao
Copy link
Author

Jars packaged with Maven do not have a bin directory

Did you follow this BUILDING GUIDE ?

yes

@lizhanhui
Copy link
Contributor

With this pull request merged, building a new docker image on commit is pretty easy with this rule

@brucebat
Copy link

brucebat commented Sep 6, 2022

Jars packaged with Maven do not have a bin directory

Did you follow this BUILDING GUIDE ?

It works, thanks. But it would be better to indicate where to get the ZIP file.

@ltamber
Copy link
Contributor

ltamber commented Sep 7, 2022

Jars packaged with Maven do not have a bin directory

Did you follow this BUILDING GUIDE ?

It works, thanks. But it would be better to indicate where to get the ZIP file.

the ZIP file is in the rocketmq/distribution/target, and it would be great if you could submit a pr optimize the BUILDING

@HattoriHenzo
Copy link

you can look at rocketmq-docker, and edit the Dockerfile and replace the file rocketmq-all-${ROCKETMQ_VERSION}-bin-release.zip

@ltamber Hi, can you please provide a sample file where you replace the remote version with the local one?

Copy link

This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.

@github-actions github-actions bot added the stale label May 14, 2024
Copy link

This issue was closed because it has been inactive for 3 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants