Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown lint workflow #5038

Open
aaron-ai opened this issue Sep 9, 2022 · 11 comments
Open

Add markdown lint workflow #5038

aaron-ai opened this issue Sep 9, 2022 · 11 comments
Assignees
Labels
Good First Issue Good First Issue

Comments

@aaron-ai
Copy link
Member

aaron-ai commented Sep 9, 2022

Markdown is a lightweight markup language for creating formatted text, but there are various implementations.

To unify the specs of our docs, a markdown lint workflow is essential. An example could be referred here: https://github.com/apache/rocketmq-clients/blob/master/.github/workflows/markdown_lint.yml

@aaron-ai aaron-ai added the Good First Issue Good First Issue label Sep 9, 2022
@selectbook
Copy link
Contributor

hi, can i hava a try?

@aaron-ai
Copy link
Member Author

hi, can i hava a try?

That's great! I assigned it to you.

@sunheyi6
Copy link

Markdown is a lightweight markup language for creating formatted text, but there are various implementations.

To unify the specs of our docs, a markdown lint workflow is essential. An example could be referred here: https://github.com/apache/rocketmq-clients/blob/master/.github/workflows/markdown_lint.yml

just copy this file?

@aaron-ai
Copy link
Member Author

aaron-ai commented Oct 28, 2022

@shy-share Hi, Thanks your attetion, the existing markdown files are also need to be fixed to pass the markdown-lint check.

@sunheyi6
Copy link

@shy-share Hi, Thanks your attetion, the existing markdown files are also need to be fixed to pass the markdown-lint check.

@aaron-ai I've learned so far that this is an npn tool that requires a style file, this should be the same as in the link, so just use npn to fix it automatically? Still don't quite understand how it's going to work.

@aaron-ai
Copy link
Member Author

It seems that markdownlint could fix some basic errors, but not all. markdownlint is more concerned with style checking.

I'am not sure whether there is some errors you need to fix it manually. anyway, just fix it and pass the check.

@Abhijeetmishr
Copy link
Contributor

@aaron-ai @Oliverwqcwrw can I pick this Up ?

@aaron-ai
Copy link
Member Author

@Abhijeetmishr Of course, I assigned it to you.

@Abhijeetmishr
Copy link
Contributor

@aaron-ai I am aware on markdown file but what exactly we have to change/update ?
Can you please explain a bit if possible ?

Regards

@Abhijeetmishr
Copy link
Contributor

@aaron-ai I am aware on markdown file but what exactly we have to change/update ? Can you please explain a bit if possible ?

Regards

@aaron-ai @Oliverwqcwrw I will appreciate any help/hints.

@AayushSaini101
Copy link
Contributor

Hi @aaron-ai Please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good First Issue
Projects
None yet
Development

No branches or pull requests

5 participants