Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split REVIEW state #57

Open
iamamoose opened this issue Jan 12, 2023 · 4 comments
Open

Split REVIEW state #57

iamamoose opened this issue Jan 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@iamamoose
Copy link
Member

iamamoose commented Jan 12, 2023

Split REVIEW state: Since states are our internal state and not Mitres state and can be anything, we could always have a PMC-REVIEW vs SECURITY-REVIEW to make it clear who has the action of doing the review. This is because some PMC's like to have the REVIEW state as part of their process and that makes sense.

This way we could also enforce the state changes (i.e. can't leave security-review without someone in security doing the state change)

@iamamoose iamamoose added the enhancement New feature or request label Jan 12, 2023
@iamamoose iamamoose changed the title Split REVIEW state Changes to internal state workflow Jan 22, 2023
@iamamoose
Copy link
Member Author

this change needs to be done in a larger context of changes to the state workflow. what states are needed, when and who moves between them, acl's on those changes, notifications on those changes (etc)

@iamamoose
Copy link
Member Author

replaces: #42

@iamamoose
Copy link
Member Author

replaces: #41

@raboof raboof mentioned this issue Jan 24, 2023
7 tasks
@raboof raboof changed the title Changes to internal state workflow Split REVIEW state Jan 24, 2023
@raboof
Copy link
Member

raboof commented Jan 24, 2023

(I moved the 'overall' changes to an 'umbrella' ticket at #61 and renamed this one back to 'Split REVIEW state')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants