Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parsing SHOW PROCEDURE STATUS for mysql #13131

Closed
tuichenchuxin opened this issue Oct 19, 2021 · 5 comments
Closed

support parsing SHOW PROCEDURE STATUS for mysql #13131

tuichenchuxin opened this issue Oct 19, 2021 · 5 comments

Comments

@tuichenchuxin
Copy link
Contributor

tuichenchuxin commented Oct 19, 2021

Hi community,

This issue can be a good first try.

Aim

support parse mysql administration statements sql SHOW PROCEDURE STATUS

Basic Qualifications

  • java
  • maven
  • antlr4

Detail

We have completed the clone rule in DALStatement.g4.
But have not yet implement the visit method in shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java
To complete this issue, I think we should complete these steps:

  • Create MySQLShowProcedureStatusStatement class in this package org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal
  • Add rule in shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/visitor/SQLVisitorRule.java
  • Implement the visit method in shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java.
  • Finally, add test for parse clone statement in shardingsphere-test module

Example FYI

@ThanoshanMV
Copy link
Member

Hi @tuichenchuxin, could you please let me know how can I reproduce this parsing failure.

@ThanoshanMV
Copy link
Member

Thank you @tuichenchuxin.

@menghaoranss menghaoranss modified the milestones: 5.0.0, 5.0.1 Oct 31, 2021
@flycash
Copy link
Member

flycash commented Nov 15, 2021

I found that there was already MySQLShowProcedureStatusStatement, so it was addressed, right?

@tuichenchuxin
Copy link
Contributor Author

@flycash yes,it has been completed, I'll close it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants