Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parsing SHOW REPLICAS for mysql #13135

Closed
tuichenchuxin opened this issue Oct 19, 2021 · 1 comment · Fixed by #13458
Closed

support parsing SHOW REPLICAS for mysql #13135

tuichenchuxin opened this issue Oct 19, 2021 · 1 comment · Fixed by #13458
Assignees
Milestone

Comments

@tuichenchuxin
Copy link
Contributor

Hi community,

This issue can be a good first try.

Aim

support parse mysql administration statements sql SHOW REPLICAS

Basic Qualifications

  • java
  • maven
  • antlr4

Detail

Add antlr rule in DALStatement.g4. refer to https://dev.mysql.com/doc/refman/8.0/en/show-replicas.html
Implement the visit method in shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java
To complete this issue, I think we should complete these steps:

  • Create anltr rule in DALStatement.g4
  • Create MySQLShowReplicasStatement class in this package org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.dal
  • Add rule in shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/database/visitor/SQLVisitorRule.java
  • Implement the visit method in shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/impl/MySQLDALStatementSQLVisitor.java.
  • Finally, add test for parse clone statement in shardingsphere-test module

Example FYI

@dongzl
Copy link
Contributor

dongzl commented Nov 3, 2021

I will try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants