Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit test for EncryptAlgorithmMetaData, EncryptRule and EncryptTable #13807

Closed
3 tasks done
strongduanmu opened this issue Nov 26, 2021 · 6 comments
Closed
3 tasks done

Add more unit test for EncryptAlgorithmMetaData, EncryptRule and EncryptTable #13807

strongduanmu opened this issue Nov 26, 2021 · 6 comments
Assignees
@zzs52 @lovestaryouth
Labels
good first issue in: test
Milestone
5.1.0

Comments

@strongduanmu
Copy link
Member

strongduanmu commented Nov 26, 2021 •
edited

Hi, community:

This issue is to add more unit tests for the EncryptAlgorithmMetaData, EncryptRule and EncryptTable classes. Welcome to claim them.

The specific subtasks are as follows:

  • Add unit test for EncryptAlgorithmMetaData#isQueryWithCipherColumn
  • Add unit test for EncryptRule#isQueryWithCipherColumn
  • Add unit test for EncryptTable#getQueryWithCipherColumn

Through this issue, you can understand the process of participating in Apache ShardingSphere, and be familiar with Encrypt-related APIs.
@strongduanmu strongduanmu added this to the 5.0.1 milestone Nov 26, 2021
@lovestaryouth
Copy link

新人报道，请多关照

@strongduanmu
Copy link
Member Author

Hi @lovestaryouth welcome here, can you translate your comment to english?

@lovestaryouth
Copy link

I come back with regret for my foolish early

@menghaoranss menghaoranss modified the milestones: 5.1.0, 5.1.1 Dec 27, 2021
@zzs52
Copy link
Contributor

zzs52 commented Jan 1, 2022

Can I try?

@strongduanmu
Copy link
Member Author

Can I try?

@zzs52 Of course.

@zzs52 zzs52 mentioned this issue Jan 9, 2022
Merged
@strongduanmu
Copy link
Member Author

Fixed by #14630.

@menghaoranss menghaoranss modified the milestones: 5.1.1, 5.1.0 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzs52 zzs52

@lovestaryouth lovestaryouth

Labels
good first issue in: test
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
4 participants
@strongduanmu @menghaoranss @zzs52 @lovestaryouth