Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM on Oracle 12.2 when load column metadata #23432

Merged
merged 1 commit into from Jan 9, 2023

Conversation

CLSChenml
Copy link
Contributor

Fixes #23013 .

Changes proposed in this pull request:

  • Added null value handling to resolve NPM issues when obtaining metadata in Oracle12.2 environment.
  • Added unit test for it.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

* Added null value handling to resolve NPM issues when obtaining metadata in Oracle12.2 environment.

* Added unit test for it.
@codecov-commenter
Copy link

Codecov Report

Merging #23432 (7e3480b) into master (0de54e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #23432      +/-   ##
============================================
- Coverage     49.83%   49.82%   -0.01%     
  Complexity     2461     2461              
============================================
  Files          4081     4080       -1     
  Lines         58280    58276       -4     
  Branches       9253     9253              
============================================
- Hits          29041    29035       -6     
- Misses        26683    26684       +1     
- Partials       2556     2557       +1     
Impacted Files Coverage Δ
...ema/loader/dialect/OracleSchemaMetaDataLoader.java 86.90% <100.00%> (+0.15%) ⬆️
...ontend/executor/ConnectionThreadExecutorGroup.java 73.33% <0.00%> (-13.34%) ⬇️
...gsphere/agent/core/plugin/jar/PluginJarLoader.java 0.00% <0.00%> (ø)
.../plugin/yaml/loader/PluginConfigurationLoader.java
...or/config/AdvisorConfigurationRegistryFactory.java
...advisor/yaml/entity/YamlAdvisorsConfiguration.java
...yaml/swapper/YamlAdvisorsConfigurationSwapper.java
...advisor/yaml/entity/YamlPointcutConfiguration.java
...aml/entity/YamlPointcutParameterConfiguration.java
...r/yaml/loader/YamlAdvisorsConfigurationLoader.java
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@strongduanmu strongduanmu merged commit 2b53c65 into apache:master Jan 9, 2023
@CLSChenml CLSChenml deleted the 23013 branch January 9, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OracleSchemaMetaDataLoader.loadColumnMetaData throw NPE when using Oracle 12.2.0.1
3 participants