Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split db-discovery feature from ShardingSphere into separate branch #24486

Closed
zhaojinchao95 opened this issue Mar 7, 2023 · 3 comments
Closed

Comments

@zhaojinchao95
Copy link
Contributor

zhaojinchao95 commented Mar 7, 2023

Hi community,

Currently, ShardingSphere database discovery feature provides the function of automatically discovery the master-slave relationship of the database and dynamically correct the status of the data source. It supports MySQLopenGauss database type.

We consider remove this feature, beancase the design of db-discovery and dynamic readwrite-splitting of ShardingSphere seems unreasonable, ShardingSphere readwrite-splitting should kept concise and not should rely master-slave role and read datasource lists of database discovery.

During the actual development and use, we encountered many problems:

  • The database discovery does not meet the pluggable architecture of ShardingSphere, it needs to pass the constructed rule to readwrite-splitting.
  • ShardingSphere does not provide database high availability, it relies on three-party high-availability solutions to find master-slave topological relationship, there are too many three-party high-availability solutions and they are very complicated, so it is a great challenge for the ShardingSphere database discovery feature.
  • The database discovery function awareness may cause the entire read cluster to be unavailable when use ApsaraDB for reading cluster domain names.

Therefore, we intend to remove db-discovery feature in ShardingSphere into a separate branch for maintenance to reduce the cost of understanding and maintaining the main code.

Please voice your opinions as fully as possible. Thank you.

@zhaojinchao95 zhaojinchao95 added this to the 5.3.2 milestone Mar 7, 2023
@zhaojinchao95 zhaojinchao95 changed the title Consider remove db-discovery feature of ShardingSphere Split db-discovery feature from ShardingSphere into separate branch Mar 7, 2023
@strongduanmu
Copy link
Member

I completely agree with it. These problems in database discovery have limited the development of ShardingSphere. It is time to remove it from the master branch.

@zhaojinchao95
Copy link
Contributor Author

The issue are finished, so i close it.

@zhaojinchao95
Copy link
Contributor Author

This issue are finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants