Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support snakeyaml 2.0. #28067

Closed
Pik1031 opened this issue Aug 14, 2023 · 3 comments · Fixed by #28805
Closed

Please support snakeyaml 2.0. #28067

Pik1031 opened this issue Aug 14, 2023 · 3 comments · Fixed by #28805
Assignees
Labels
stale type: dependencies Pull requests that update a dependency file type: question

Comments

@Pik1031
Copy link

Pik1031 commented Aug 14, 2023

Feature Request

For English only, other languages will not be accepted.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

When snakeyaml 2.0 is used in a project, an error is reported and the project cannot be started.

Describe the feature you would like.

Please support snakeyaml 2.0.

@RaigorJiang
Copy link
Contributor

Hi @Pinkman-oss
ShardingSphere currently uses snakeyaml version 1.3.3, can you provide a work list for upgrading to 2.0?
Like what improvements does it bring, and are there any api changes?

@RaigorJiang RaigorJiang added type: question type: dependencies Pull requests that update a dependency file labels Aug 15, 2023
@SingKS8
Copy link

SingKS8 commented Aug 26, 2023

The most common conflict issues with snakeyaml 2.0 are that the default constructor of org.yaml.snakeyaml.representer.Representer is deprecated in 1.33 and remove in 2.0, in my opinion, even if snakeyaml team keep development about 1.x version series, shardingsphere team should have a plan about updating api which has deprecated.

I feel a little disappointed in this issuse is that your guy a contributor of this project under apache foundation, let a common community member who is not in development to provide a work list? I think keeping api updates and avoiding vulnerabilities, should be responsibility of the core team.

@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale type: dependencies Pull requests that update a dependency file type: question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants