Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0-alpha did not delete the datasource.common prop #9003

Closed
boynicholas opened this issue Jan 12, 2021 · 5 comments
Closed

5.0.0-alpha did not delete the datasource.common prop #9003

boynicholas opened this issue Jan 12, 2021 · 5 comments
Assignees

Comments

@boynicholas
Copy link

Bug Report

For English only, other languages will not accept.

I can't understand that the documentation and everything in the instructions don't mention this, the 5.0.0-alpha in the Maven repository doesn't remove datasource.common props, which caused me to have to carry datasource.common in application.yml.

However, when I use the Hikari pool, this still does not allow me to omit the jdbc url attribute in the common as in the original version, which causes Hikari to not find the url

@boynicholas
Copy link
Author

I think the problem has been found, the url must be modified to jdbc-url, is it considered to modify this one?

@tristaZero
Copy link
Contributor

I think the problem has been found, the url must be modified to jdbc-url, is it considered to modify this one?

Hi, the document gives users wrong configuration?

@JiekerTime
Copy link
Member

@aBoyNicholas In 5.0.0 apha, if your springboot version is 2.x, you really need to configure datasourse.common. However, under 2.x, you do not need to configure at all.
The datasourse.common will be removed in the future.

@yu199195
Copy link
Member

In 5.0.0 apha, if your springboot version is 2.x, you really need to configure datasourse.common. However, under 2.x, you do not need to configure at all.
The datasourse.common will be removed in the future.

this is right..

@tristaZero
Copy link
Contributor

Hi @aBoyNicholas
This issue has been open for 14 days. If you got the answer, please close it.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants