Feature-#10481 - use startup probe option for first initialization of application #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
reviewed
Mar 7, 2023
Comment on lines
106
to
109
| tcpSocket: | ||
| port: 12800 | ||
| failureThreshold: 9 | ||
| periodSeconds: 10 |
There was a problem hiding this comment.
What do you think if we remove this (Line 106 ~ Line 109) and uncomment the startupProbe section in values.yaml?
… application Applications take longer to start up the first time. In these situations, setting up liveness probe parameters might be challenging without sacrificing the quick response time that led to the probe's creation. Setting up a startup probe with the same command, HTTP or TCP check, and a failureThreshold* periodSeconds long enough to account for the worst-case startup delay is therefore a good idea.
rabajaj0509
force-pushed
the
startup-probe
branch
from
9d451da
to
54ddf63
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications take longer to start up the first time. In these situations, setting up liveness probe parameters might be challenging without sacrificing the quick response time that led to the probe's creation. Setting up a startup probe with the same command, TCP check, and a failureThreshold* periodSeconds long enough to account for the worst-case startup delay is therefore a good idea.