modify role to clusterrole #21
Conversation
|
@wu-sheng @hanahmily help review |
|
Most of it looks great. Thanks @innerpeacez. We leverage oap permission here is because envoy recevier intends to access API server get information across the entire cluster. So a more fine grain method is to identify whether user opens this receiver then grant oap a appropriate permission. Well, this way is much simpler for our user. Can you document it in README. md |
@innerpeacez I think env varible description, helm guide and API server grant, should be added in this doc, https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/als_setting.md#observe-service-mesh-through-als |
|
Change the document step 2-3 and guide the user to use the helm, please |
|
I will add a |
|
@hanahmily @wu-sheng Help review again,thanks . |
|
If there are no problems, I will merge this PR |
| ```yaml | ||
| oap: | ||
| envoy: | ||
| sla: |
| When envoy sla , will give ServerAccount clusterrole permission. | ||
| More envoy sla ,please refer to https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/als_setting.md#observe-service-mesh-through-als |
|
|
||
| Envoy ALS(access log service) provides fully logs about RPC routed, including HTTP and TCP. | ||
|
|
||
| If you want to open envoy sla, you can do this by modifying values.yaml. |
There was a problem hiding this comment.
and should be upper-case
| @@ -56,6 +56,7 @@ The following table lists the configurable parameters of the Skywalking chart an | |||
| | `oap.nodeSelector` | OAP labels for master pod assignment | `{}` | | |||
| | `oap.tolerations` | OAP tolerations | `[]` | | |||
| | `oap.resources` | OAP node resources requests & limits | `{} - cpu limit must be an integer` | | |||
| | `oap.envoy.sla.enabled` | Open envoy sla | `false` | | |||
| envoy: | ||
| als: | ||
| enabled: false | ||
| # more envoy sla ,please refer to https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/als_setting.md#observe-service-mesh-through-als |
|
@innerpeacez after some typo is fixed I think it's fine to merge it. |
No description provided.