New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http ignore by method #143
Conversation
tom-pytel
commented
Aug 4, 2021
- Added SW_HTTP_IGNORE_METHOD which will allow ignoring http operations by method (GET, POST, HEAD, OPTIONS, etc...)
- Set default SW_AGENT_MAX_BUFFER_SIZE back to 10000 from 1000, which turns out to be too small for python (many unnecessarily dropped spans).
I've noticed sanic 20.3.0 test fail intermittently 2 or 3 times now... |
@kezhenxu94 - Here you have a perfect case, this test for this python version passed before but failed now even though it worked before and now for other python versions. Can you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look at the sanic case
Still failing, do you have access to the logs to see why? [EDIT] I don't mean the normal generated logs, I mean like for the consumer which seems to be failing for this particular sanic test? |
sanic test case seems to always fail in Python 3.8, need to check why |
I did a basic check on my side with python 3.8.11 and sanic 20.3.0 and it works, (note, the exception is intentional when the server was accessed to test error):
|
Didn't reproduce locally or in another branch https://github.com/apache/skywalking-python/runs/3252404801 |
20.3.0 worked this time, what did you change? |
Seems to be stuck on starting CheckStatus test... |
Didn't change anything, it seems to be unstable, not constantly fail. |
This is GitHub action issue, maybe the job is bot scheduled. |
Ok. GitHub actions is degraded. Let's merge this anyway. |
Tried to merge locally and push to github master but no luck (I guess as comitter I don't have these permissions?):
|
This time sanic 20.3.0 failed for py 3.9... |
Disabled sanic 20.3.0 test for now. |