Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report metrics related to pvm #238

Merged
merged 8 commits into from Oct 18, 2022

Conversation

jiang1997
Copy link
Contributor

@jiang1997 jiang1997 commented Sep 24, 2022

Metrics

CPU

total_cpu_utilization

process_cpu_utilization

cpu utilization of the current process

thread_active_count

number of threads invoked by the current process and its children

Memory

total_mem_utilization

process_mem_utilization

memory utilization of the current process

GC

gc_g0

number of objects of generation 0

gc_g1

number of objects of generation 1

gc_g2

number of objects of generation 2

gc_time

For now, MeterReportService is available with gRPC only. So does the e2e test.
I will implement MeterReportService and enable e2e test for Kafka later.

Welcome any advice about naming.

@Superskyyy
Copy link
Member

Superskyyy commented Sep 25, 2022

Will need to add a E2E testing case to the PR.

@wu-sheng
Copy link
Member

When using MAL to analysis PVM metrics, a new MAL file should be added and activated in the server side, as well as UI.
So, we need to add one side without e2e, or manually mount one file, and remove later after backend PR accepted.

@jiang1997
Copy link
Contributor Author

When using MAL to analysis PVM metrics, a new MAL file should be added and activated in the server side, as well as UI. So, we need to add one side without e2e, or manually mount one file, and remove later after backend PR accepted.

Thanks for the suggestion. For now, I manually mount MAL files and will create necessary PR to Skywalking backend later.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 3, 2022

You could refer apache/skywalking#9711 to make backend PR ready.

@easonyipj You could ref this to take a look at agent side testing.

@easonyipj
Copy link

You could refer apache/skywalking#9711 to make backend PR ready.

@easonyipj You could ref this to take a look at agent side testing.

OK, I got it, thanks.

@jiang1997
Copy link
Contributor Author

jiang1997 commented Oct 3, 2022

You could refer apache/skywalking#9711 to make backend PR ready.

@easonyipj You could ref this to take a look at agent side testing.

Got it.

@Superskyyy
Copy link
Member

Any updates?

@jiang1997 jiang1997 marked this pull request as ready for review October 17, 2022 03:24
@jiang1997
Copy link
Contributor Author

jiang1997 commented Oct 17, 2022

Any updates?

I plan to implement MeterReportService and enable e2e test for Kafka, but it didn't go very well. Anyway, it's ready for review.

@Superskyyy
Copy link
Member

Any updates?

I plan to implement MeterReportService and enable e2e test for Kafka, but it didn't go very well. Anyway, it's ready for review.

I will reach you out for a discussion on the kafka part. cc: @kezhenxu94 for a review of this PR.

@Superskyyy
Copy link
Member

Superskyyy commented Oct 18, 2022

Kafka issue is solved, OAP is expecting MeterDataCollection instead of MeterData

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@kezhenxu94 kezhenxu94 merged commit 877928f into apache:master Oct 18, 2022
@kezhenxu94
Copy link
Member

Next we need to configure the UI dashboard in the main repo

@jiang1997
Copy link
Contributor Author

Next we need to configure the UI dashboard in the main repo

Get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature New feature
Projects
None yet
5 participants