Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] [KV] Use the table builder to compress/decompress data. #10118

Closed
2 of 3 tasks
hanahmily opened this issue Dec 6, 2022 · 0 comments · Fixed by apache/skywalking-banyandb#230
Closed
2 of 3 tasks

[Feature] [KV] Use the table builder to compress/decompress data. #10118

hanahmily opened this issue Dec 6, 2022 · 0 comments · Fixed by apache/skywalking-banyandb#230
Assignees
@hanahmily
Labels
database BanyanDB - SkyWalking native database feature New feature
Milestone
BanyanDB - 0.3.0

Comments

@hanahmily
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The table builder’s compression procedure is a better injection point than the current implementation. The current KV block compression is only based on size. We could refactor it based on the key prefix and the size. That means a block only contains data with the same key.

The new strategy is neater than the previous one. We could remove most codes from our branch, including TSet, the new subcompact, and exported Handover. The table builder should import the bydb package to implement a unique compression/decompression algorithm.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@hanahmily hanahmily added feature New feature database BanyanDB - SkyWalking native database labels Dec 6, 2022
@hanahmily hanahmily added this to the BanyanDB - 0.3.0 milestone Dec 6, 2022
@hanahmily hanahmily self-assigned this Dec 6, 2022
@hanahmily hanahmily mentioned this issue Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanahmily hanahmily

Labels
database BanyanDB - SkyWalking native database feature New feature
Projects
None yet
Milestone
BanyanDB - 0.3.0
Development

Successfully merging a pull request may close this issue.

Opt to a new encoding system apache/skywalking-banyandb
1 participant
@hanahmily