Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add hierarchy for RabbitMQ layer #11926

Closed
3 tasks done
peachisai opened this issue Feb 25, 2024 · 4 comments · Fixed by #11935
Closed
3 tasks done

[Feature] Add hierarchy for RabbitMQ layer #11926

peachisai opened this issue Feb 25, 2024 · 4 comments · Fixed by #11935
Assignees
Labels
backend OAP backend related. feature New feature
Milestone

Comments

@peachisai
Copy link
Contributor

peachisai commented Feb 25, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

As skywalking 10 supporting service hierarchy , RabbitMQ layer could be related from span peer and k8s service to RabbitMQ monitoring

Use case

skywaling-showcase

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@peachisai peachisai added the feature New feature label Feb 25, 2024
@wu-sheng wu-sheng added the backend OAP backend related. label Feb 25, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Feb 25, 2024

@peachisai If you have any uncertain questions about building hierarchy please let me and @wankai123 know.

@peachisai
Copy link
Contributor Author

@wu-sheng @wankai123
image
This is my question
Rule:
image
Showcase:
image
image

Should I pull an another PR about changing skywalking-showcase RabbitMQ monitoring service name to
rabbitmq.skywalking-showcase for building the relationship from RabbitMQ monitoring to k8slayer?

@peachisai
Copy link
Contributor Author

@peachisai If you have any uncertain questions about building hierarchy please let me and @wankai know.

Ok , I will. BTW, you seems @ an another irrelavant person :D

@wu-sheng
Copy link
Member

I think name should be changed to align with the hierarchy detection mechanism requirements, as same as RocketMQ did.

@wu-sheng wu-sheng linked a pull request Feb 26, 2024 that will close this issue
2 tasks
@wu-sheng wu-sheng added this to the 10.0.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants