Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support to query relation metrics through PromQL #12245

Closed
2 of 3 tasks
wu-sheng opened this issue May 22, 2024 · 11 comments · Fixed by #12316
Closed
2 of 3 tasks

[Feature] Support to query relation metrics through PromQL #12245

wu-sheng opened this issue May 22, 2024 · 11 comments · Fixed by #12316
Assignees
Labels
backend OAP backend related. feature New feature good first issue Good first issue for beginners
Milestone

Comments

@wu-sheng
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

PromQL Service doesn't support metrics of relation between services, instances or endpoints.

Use case

User could use this to build dashboards to show metrics from the lines on the topology or manually click.

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@wu-sheng wu-sheng added backend OAP backend related. feature New feature good first issue Good first issue for beginners labels May 22, 2024
@wu-sheng
Copy link
Member Author

@CzyerChen @weixiang1862 @yswdqz Any of you has interest in implementing this?

@theboywholived
Copy link

I am new to this repo - would like to pick this up.
Can you add some more verbose details of what is required as part of the feature?

@wu-sheng
Copy link
Member Author

I am new to this repo - would like to pick this up.

Can you add some more verbose details of what is required as part of the feature?

This is not easy. Do you read most of SkyWalking codebases?

@theboywholived
Copy link

I will have to do that. I am brand-new to this repo.

@wu-sheng
Copy link
Member Author

I would say, you could consider to implement this. But don't be in urgent.

This requires you to have good understanding of the whole system.

@theboywholived
Copy link

I would like to take a shot at this. I will go through the docs and readme. Is there anything else you suggest me to do? Or a similar MR for a different Query language?

@wu-sheng
Copy link
Member Author

You could do as following

  1. Get familiar with project, and how to run showcase. https://skywalking.apache.org/docs/skywalking-showcase/next/readme/
  2. Learn MQE about the protocol and native UI for relative metrics.
  3. Learn PromQL service, and workflow.
  4. Try to implement this.

@theboywholived
Copy link

Okay, let me do as you recommend.

@theboywholived
Copy link

@wu-sheng I only have 16 GB RAM in my mac, I am not able to run showcase:
Release "demo" does not exist. Installing it now.
It's stuck on this step with RAM Utilization spiking up.

Is there another alternative?

@wu-sheng
Copy link
Member Author

You need to run necessary components only. Don't run the default. It includes all features.

@wu-sheng wu-sheng added this to the 10.1.0 milestone May 29, 2024
@wu-sheng
Copy link
Member Author

@yswdqz told me, he will work on this from June 2nd/3th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature good first issue Good first issue for beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants