Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Agent] Integrate the spanId into log components #388

Closed
wu-sheng opened this issue Sep 4, 2017 · 7 comments · Fixed by #6213
Closed

[Agent] Integrate the spanId into log components #388

wu-sheng opened this issue Sep 4, 2017 · 7 comments · Fixed by #6213
Labels
agent Language agent related. good first issue Good first issue for beginners
Milestone
8.4.0

Comments

@wu-sheng
Copy link
Member

wu-sheng commented Sep 4, 2017

We have already supported to integrate the traceId into log components, I think we should support spanId either.
@wu-sheng wu-sheng added this to the 3.4-2017 milestone Sep 4, 2017
@wu-sheng wu-sheng modified the milestones: 3.4-2017, 5.0-2018-preview Dec 7, 2017
@wu-sheng wu-sheng changed the title Integrate the spanId into log components [Agent] Integrate the spanId into log components Dec 12, 2017
@wu-sheng wu-sheng added the agent Language agent related. label Feb 8, 2018
@wu-sheng wu-sheng modified the milestones: 5.0.0-alpha, 5.0.0-beta Mar 5, 2018
@wu-sheng
Copy link
Member Author

wu-sheng commented Mar 5, 2018

Low priority requirement, no community feedback.

@ygsama
Copy link

ygsama commented May 20, 2019

If collection log with ELK and SkyWalking-6.1, we mast to Integrate the spanID or others in log components ourselves ?

@wu-sheng wu-sheng added good first issue Good first issue for beginners help wanted labels May 20, 2019
@wu-sheng
Copy link
Member Author

@ygsama The traceid is available there, we are welcome contribution to provide span id API.

@wu-sheng
Copy link
Member Author

@tristaZero If you like to try agent contribution, this is a good one.

@dagmom
Copy link
Contributor

dagmom commented Jun 7, 2020

@tristaZero If you like to try agent contribution, this is a good one.

log spanId after traceId?

can i try contribute this issue @wu-sheng

@wu-sheng
Copy link
Member Author

@dagmom If you want, welcome to do, but personally, I think #4545 is more meaningful?

@tristaZero
Copy link
Contributor

Welcome. :-)

@wu-sheng wu-sheng linked a pull request Jan 15, 2021 that will close this issue
export the segmentId and spanId in toolkit #6213
Merged
@wu-sheng wu-sheng added this to the 8.4.0 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent Language agent related. good first issue Good first issue for beginners
Projects
None yet
Milestone
8.4.0
Development

Successfully merging a pull request may close this issue.

export the segmentId and spanId in toolkit EvanLjp/skywalking
5 participants
@wu-sheng @ascrutae @tristaZero @ygsama @dagmom