Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alarm-settings.yml support exclude-names #3939

Closed
1 of 4 tasks
stalary opened this issue Nov 26, 2019 · 8 comments
Closed
1 of 4 tasks

alarm-settings.yml support exclude-names #3939

stalary opened this issue Nov 26, 2019 · 8 comments
Assignees
Labels
backend OAP backend related. feature New feature
Milestone

Comments

@stalary
Copy link
Contributor

stalary commented Nov 26, 2019

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?
    why alarm-settings.yml support only include-names, but not exclude-names? I have some upload interfaces that take a long time,it will trigger the alarm a lot

Bug

  • Which version of SkyWalking, OS and JRE?

  • Which company or project?

  • What happen?
    If possible, provide a way for reproducing the error. e.g. demo application, component version.


Requirement or improvement

  • Please describe about your requirements or improvement suggestions.
    supoort exclude-names
@wu-sheng
Copy link
Member

No difference from my side. No special reason.

@wu-sheng wu-sheng added this to the 6.6.0 milestone Nov 26, 2019
@wu-sheng wu-sheng added the question End user question and discussion. label Nov 26, 2019
@stalary
Copy link
Contributor Author

stalary commented Nov 26, 2019

No difference from my side. No special reason.

So how do I rule out long response time endpoints

@wu-sheng
Copy link
Member

wu-sheng commented Nov 26, 2019

I think you misunderstand my point, only have either exclude or include is same. So we have only one. If you want to support both, contribution is welcome.

@stalary
Copy link
Contributor Author

stalary commented Nov 26, 2019

I think you misunderstand my point, only have either exclude or include is same. So we have only one. If you want to support both, contribution is welcome.

I have thousands of endpoints here, I have to write thousands of includes, so include can be cumbersome for me.

@stalary
Copy link
Contributor Author

stalary commented Nov 26, 2019

If the project design allows, I will support both recently

@wu-sheng
Copy link
Member

I know. So I said if you want to add exclude, it is fine and welcome. But don't remove the include, which will cause others' issue. Do you get my point?

@wu-sheng wu-sheng reopened this Nov 26, 2019
@wu-sheng wu-sheng added backend OAP backend related. feature New feature help wanted and removed question End user question and discussion. labels Nov 26, 2019
@stalary
Copy link
Contributor Author

stalary commented Nov 26, 2019

I know, I meant to just add exclude, sorry, I didn't make myself clear at first

@stalary stalary changed the title Why alarm-settings.yml support only include-names, but not exclude-names? alarm-settings.yml support exclude-names Nov 26, 2019
@wu-sheng
Copy link
Member

New feature is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants