Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIGNX-LUA] Nginx plugin/module #4258

Closed
1 of 4 tasks
kezhenxu94 opened this issue Jan 17, 2020 · 5 comments
Closed
1 of 4 tasks

[NIGNX-LUA] Nginx plugin/module #4258

kezhenxu94 opened this issue Jan 17, 2020 · 5 comments
Assignees
Labels
agent Language agent related. core feature Core and important feature. Sometimes, break backwards compatibility.

Comments

@kezhenxu94
Copy link
Member

  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

As required by the community and the discussion between @wu-sheng and I, we're considering to provide a plugin/module in Nginx(maybe written in Lua), to make it possible to begin a trace in Nginx, or create spans in Nginx, the plugin/module should behave similar (in some degree) to that in Java agent, more details and progress will be synchronized here, hopefully

@kezhenxu94 kezhenxu94 added the TBD To be decided later, need more discussion or input. label Jan 17, 2020
@wu-sheng
Copy link
Member

I would suggest this in a separate repo and do release independently. Of course, we need 7.0.0 release to work with it, unless we plan to use lua-grpc.
Due to new repo, please send a dev mail, and get permission from PMC.

@wu-sheng
Copy link
Member

Also, after the setup is permitted, set up a new milestone for skywalking-nginx-lua subproject.

@wu-sheng
Copy link
Member

@wu-sheng
Copy link
Member

Another repo creation proposal has sent to the mail list.

@wu-sheng wu-sheng added this to the NIGNX-LUA 0.1.0 milestone Feb 19, 2020
@wu-sheng wu-sheng added agent Language agent related. core feature Core and important feature. Sometimes, break backwards compatibility. and removed TBD To be decided later, need more discussion or input. labels Feb 23, 2020
@wu-sheng wu-sheng changed the title Nginx plugin/module [NIGNX-LUA] Nginx plugin/module Feb 23, 2020
@wu-sheng
Copy link
Member

Finished by me. It belongs to another sub project , check the repo, https://github.com/apache/skywalking-nginx-lua.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. core feature Core and important feature. Sometimes, break backwards compatibility.
Projects
None yet
Development

No branches or pull requests

2 participants