Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] MySQL e2e test could pass even MySQL driver downloaded failure. #4343

Closed
wu-sheng opened this issue Feb 10, 2020 · 5 comments
Closed
Assignees
Labels
high priority High priority issue, blocking next release. test Test requirements about performance, feature or before release.
Milestone

Comments

@wu-sheng
Copy link
Member

We detected a high priority e2e test issue at #4335, the download link of MySQL driver is dead, but the e2e test could pass every time.

This is a high priority test issue, which makes reviewers can't use the test to verify the codes. @kezhenxu94 please take this as the 1st priority thing to fix.

@wu-sheng wu-sheng added high priority High priority issue, blocking next release. test Test requirements about performance, feature or before release. labels Feb 10, 2020
@wu-sheng wu-sheng added this to the 7.0.0 milestone Feb 10, 2020
@wu-sheng
Copy link
Member Author

The download link will be fixed through #4335, but we need to invest why and fix it ASAP.

@dmsolr
Copy link
Member

dmsolr commented Feb 11, 2020

@kezhenxu94 , if you don't have time, I can submit a PR to pre-install the driver in e2e-container image.

@wu-sheng
Copy link
Member Author

@dmsolr The download link has been fixed, the issue is why the test passed when the download fails

@dmsolr
Copy link
Member

dmsolr commented Feb 11, 2020

got it.

@kezhenxu94
Copy link
Member

The e2e still passed because the failure (download) stops the replacement of application.yaml, and it falls back to H2 storage, this is fixed by SkyAPMTest/e2e-container@bf4cee3 and I just released e2e-container 1.5 https://hub.docker.com/r/skyapm/e2e-container/tags?page=1&ordering=last_updated since @dmsolr you're upgrading the container versions in your PR, please upgrade them to 1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High priority issue, blocking next release. test Test requirements about performance, feature or before release.
Projects
None yet
Development

No branches or pull requests

3 participants