New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about alarming local span #5019

Closed

firolololo opened this issue Jul 3, 2020 · 3 comments

Labels

question

Milestone

firolololo commented Jul 3, 2020

If i write a plugin to establish a local span to intercept the constructor of my own java class, the span will fail in some situation. I try to alarm this situation and configure alarm-setting.xml as following:

rules:

alarm

xxxxxxxx_rule:
metrics-name: endpoint_sla
op: ">"
threshold: 60
period: 10
count: 1
silence-period: 5
message: "failed"
include-names:
- com.example.className in serviceName

but not work.

Member

wu-sheng commented Jul 3, 2020

Typically, this should not work, because there are no metrics generated through local spans.
But luckily, you have an option in the master and next 8.1 release. We call that logic endpoint from the span.

Read the latest doc for more details.

wu-sheng closed this as completed

wu-sheng added this to the 8.1.0 milestone

wu-sheng added the question label

Member

wu-sheng commented Jul 3, 2020

https://github.com/apache/skywalking/blob/master/docs/en/guides/Java-Plugin-Development-Guide.md#extension-logic-endpoint-tag-key-x-le

Author

firolololo commented Jul 3, 2020 •

edited

Appreciate your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment