Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build connection between agent client and oap server with service discover #5063

Closed
1 task
EvanLjp opened this issue Jul 8, 2020 · 8 comments
Closed
1 task
Labels
discussion Discussions
Milestone

Comments

@EvanLjp
Copy link
Member

EvanLjp commented Jul 8, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
    In some cases,BACKEND_SERVICE is config as dns:port;
    some dns production is not support Load balancing,for example core dns in cncf.

so i want to add a dns lookup to support the case

@EvanLjp EvanLjp changed the title add dns add dns lookup Jul 8, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Jul 8, 2020

Just confirm, you want to do DNS lookup manually by codes, then select the backend from candidates?

@wu-sheng wu-sheng added the discussion Discussions label Jul 8, 2020
@EvanLjp
Copy link
Member Author

EvanLjp commented Jul 9, 2020

yes,maybe can support more ways,for example

  1. dns
  2. Kubernetes service

So.i want to add the feature, like kubernetes dubbo
1.Use kubernetes service as service discover
1.also supports dns nslookup

@wu-sheng
Copy link
Member

wu-sheng commented Jul 9, 2020

Do you have more material about DNS level load balancer can't work automatically? From your asking, it seems, we need codes to do a DNS lookup to get the candidate list. Am I right?

@wu-sheng
Copy link
Member

wu-sheng commented Jul 9, 2020

If you want to add new dependency on the agent core, that wouldn't be recommended, especially for this case. The way would be adding a plugin for feature extension. If there is no extension point currently, we could create one.
Anymore, I need more details about what you are trying to do. Because I don't know what dubbo-k8s did, actually, that is not have to be our reference. Agent is very different from a dev framework.

@EvanLjp
Copy link
Member Author

EvanLjp commented Jul 9, 2020

yes,i should change a new title
build the connection between agent client and oap server with service discover
for example :
Kubernetes
dns
etcd
zk
.....

create a new extension point like oap

@EvanLjp EvanLjp changed the title add dns lookup oap server with service discover Jul 9, 2020
@EvanLjp EvanLjp changed the title oap server with service discover build connection between agent client and oap server with service discover Jul 9, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Jul 9, 2020

OK, that will not be an easy job. NOTICE, receiver role OAP role is never registered through the coordinator, but your service discovery is for looking up receiver role nodes.

@wu-sheng
Copy link
Member

wu-sheng commented Jul 9, 2020

And service discovery of OAP node is not recommended in many companies, because the OAP nodes are deployed in the system/operation platform zone, rather than the business zone. Service discovery wouldn't work in this case.

@EvanLjp
Copy link
Member Author

EvanLjp commented Jul 9, 2020

OK,thx

@kezhenxu94 kezhenxu94 linked a pull request Jul 17, 2020 that will close this issue
1 task
@EvanLjp EvanLjp closed this as completed Aug 31, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants