Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC SSL certs hot reloading #5110

Closed
hanahmily opened this issue Jul 16, 2020 · 1 comment · Fixed by #5376
Closed

gRPC SSL certs hot reloading #5110

hanahmily opened this issue Jul 16, 2020 · 1 comment · Fixed by #5376
Assignees
@hanahmily
Labels
backend OAP backend related. feature New feature
Milestone
8.2.0

Comments

@hanahmily
Copy link
Contributor

When using SSL to perform the AuthN between client/agent and OAP. To make things more secure, OAP should support hot reload certs.

After some investigation, I found there're some potential solutions existing in the gRPC community, for instance, grpc/grpc-java#5335.

I prefer to delegate SSLContext, anyone who has any thoughts, pls feel free to let me know, thanks.
@hanahmily hanahmily added TBD To be decided later, need more discussion or input. backend OAP backend related. labels Jul 16, 2020
@hanahmily hanahmily self-assigned this Jul 16, 2020
@hanahmily hanahmily removed the TBD To be decided later, need more discussion or input. label Aug 24, 2020
@hanahmily
Copy link
Contributor Author

I will adopt to SSLContext delegation path to implement this feature

@hanahmily hanahmily mentioned this issue Aug 25, 2020
Merged
@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 31, 2020
@wu-sheng wu-sheng added the feature New feature label Aug 31, 2020
@wu-sheng wu-sheng mentioned this issue Sep 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanahmily hanahmily

Labels
backend OAP backend related. feature New feature
Projects
None yet
Milestone
8.2.0
Development

Successfully merging a pull request may close this issue.

Hot reload gRPC certs of OAP. apache/skywalking
2 participants
@hanahmily @wu-sheng