Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage ShardingSphere's SQL parser to get table's read/write level metrics #5838

Closed
1 of 4 tasks
wu-sheng opened this issue Nov 13, 2020 · 3 comments
Closed
1 of 4 tasks
Assignees
Labels
discussion Discussions no update The owner doesn't provide further feedback.

Comments

@wu-sheng
Copy link
Member

wu-sheng commented Nov 13, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Requirement or improvement

  • Please describe your requirements or improvement suggestions.

We were waiting for ShardingSphere's 5.0 release for a long time. Powered by that, we have the SQL parser compatibility across different SQL databases. So, we could run SQL parser at the backend in doing trace/span and ALS+SQL-log(in the future) analysis.

We should be able to get the metrics like

  1. read/write latency/traffic for table and table set.
  2. select/update metrics per database.
  3. DDL detection. As normally, there should be no DDL in the product environment.

@tristaZero When your documentation is ready, please ping us. If you want to lead this, please let us know.
@ascrutae @kezhenxu94 @hanahmily We need to keep our eyes on this and add this into the OAP in the next several weeks, especially for trace analysis first.

@ascrutae
Copy link
Member

got it!

@tristaZero
Copy link
Contributor

tristaZero commented Nov 13, 2020

Hi everyone. I am glad to see this SQL-parsing feature of ShardingSphere can come into play in Skywalking community. :-)
We spent a lot of effort and time on this important feature, though it is the first time to present it an independent feature from ShardingSphere. Some interesting ideas are still in the incubator. Stayed tuned!

The additional doc is under review and will be merged soon I suppose. Please give it a watch. :)

Best,
Trista

@wu-sheng
Copy link
Member Author

I set up the benchmarks to test the performance, apache/shardingsphere#8208. We need a deeper discussion and maybe optimization as right now, it seems would cause a big impact to the OAP.

@wu-sheng wu-sheng added the no update The owner doesn't provide further feedback. label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussions no update The owner doesn't provide further feedback.
Projects
None yet
Development

No branches or pull requests

5 participants