Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Optional plugin mechanism #658

Closed
ascrutae opened this issue Dec 11, 2017 · 2 comments
Closed

[Agent] Optional plugin mechanism #658

ascrutae opened this issue Dec 11, 2017 · 2 comments
Assignees
Labels
agent Language agent related. documentation Provide documents related issue or pull request only.
Milestone

Comments

@ascrutae
Copy link
Member

Currently SkyWalking loads all plugin jars from plugins folder to enhance class. However some plugins would probably affect the performance because of enhancing class. Or some of them are in beta. If the above plugins are put under the plugins folder, it will cause the user experience not so good and it's also not what the user wants to see. So I expect to create a new folder to put these plugins. And the user could copy the plugins jars to the plugins folder directly if they want to trace them.

@wu-sheng wu-sheng added this to the 5.0-2018-preview milestone Dec 12, 2017
@wu-sheng wu-sheng changed the title Optional plugin mechanism [Agent] Optional plugin mechanism Dec 12, 2017
@wu-sheng wu-sheng added the documentation Provide documents related issue or pull request only. label Jan 27, 2018
@wu-sheng
Copy link
Member

@ascrutae Since I just found you already did this in Spring bean plugins. Please provide a document about this.

@ascrutae ascrutae mentioned this issue Jan 28, 2018
3 tasks
@wu-sheng
Copy link
Member

Done.

@wu-sheng wu-sheng added the agent Language agent related. label Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent Language agent related. documentation Provide documents related issue or pull request only.
Projects
None yet
Development

No branches or pull requests

2 participants