Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Incompatible with versions after dubbo-2.7.14, resulting in broken tracking #8415

Closed
3 tasks done
wuwen5 opened this issue Jan 12, 2022 · 1 comment
Closed
3 tasks done

[Bug] Incompatible with versions after dubbo-2.7.14, resulting in broken tracking #8415

wuwen5 opened this issue Jan 12, 2022 · 1 comment
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! ecosystem Things related to SkyWalking, but codes hosting in 3rd-party java Java agent related
Milestone
Java - 8.9.0

Comments

@wuwen5
Copy link
Contributor

wuwen5 commented Jan 12, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Java Agent (apache/skywalking-java)

What happened

After upgrading Dubbo 2.7.15, the trace log was broken.

What you expected to happen

The rpcContext.getAttachments() method returns is copy Map.

https://github.com/apache/dubbo/pull/8772/files

How to reproduce

upgrade dubbo version >= 2.7.14

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@wuwen5 wuwen5 added the bug Something isn't working and you are sure it's a bug! label Jan 12, 2022
@wuwen5 wuwen5 mentioned this issue Jan 12, 2022
Merged
2 tasks
@wu-sheng
Copy link
Member

I think you have to ask for Dubbo community to explain this kind of important kernel-level behavior change, and why.

@wu-sheng wu-sheng added agent Language agent related. ecosystem Things related to SkyWalking, but codes hosting in 3rd-party java Java agent related labels Jan 12, 2022
@wuwen5 wuwen5 mentioned this issue Jan 12, 2022
Merged
8 tasks
@wu-sheng wu-sheng added this to the Java - 8.9.0 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent Language agent related. bug Something isn't working and you are sure it's a bug! ecosystem Things related to SkyWalking, but codes hosting in 3rd-party java Java agent related
Projects
None yet
Milestone
Java - 8.9.0
Development

No branches or pull requests
2 participants
@wuwen5 @wu-sheng